Bug 572447
| Summary: | Review Request: compat-gdbm - A GNU set of database routines compatibility library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karel Klíč <kklic> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, paul, rdieter, rvokal |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
tcallawa: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-16 15:02:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 572261 | ||
|
Description
Karel Klíč
2010-03-11 09:09:04 UTC
Dan Horak suggested to use symlinks instead of this compat package. /usr/lib/libgdbm.so.2 -> libgdbm.so.3.0.0 /usr/lib/libgdbm.so.2.0.0 -> libgdbm.so.3.0.0 I'll try that before proceeding with compat-gdbm. *** Bug 572529 has been marked as a duplicate of this bug. *** symlinks won't solve the bootstrapping problem with rpm-build/perl deps. I can help review this. 1. SHOULD: instead of building, then manually removing libgdbm.a, use %configure --disable-static 2. MUST: remove Obsoletes: gdbm <= 1.8.0, gdbm-devel <= 1.8.0 the gdbm upgrade path should go to the newer gdbm-1.8.3+ pkgs, not this one The rest looks pretty simple and good guidelines-wise. Fix these (well, at least the MUST item #2), and I'll approve this. (In reply to comment #3) > symlinks won't solve the bootstrapping problem with rpm-build/perl deps. Why do you say that? I've successfully rebuilt perl locally in mock with the new gdbm (with symlinks) in the buildroot. Spec URL: http://kklic.fedorapeople.org/compat-gdbm.spec SRPM URL: http://kklic.fedorapeople.org/compat-gdbm-1.8.0-2.fc12.src.rpm Removed `Obsoletes: gdbm...` Used %%configure --disable-static instead of removing libgdmb.a Symbolic links (libgdbm.so.2->libgdmb.so.3) and some "Provides" tags must be removed from the gdbm package _before_ this package goes to rawhide. Re: comment #6 the symlinks didn't help there, but the fake Provides One last minor comment, the auto*foo modifications should be in %setup, not %build section. But, I won't block on that. Thanks for the modifications. APPROVED. Correct too about the hacks to main gdbm package need to be removed before this lands. The hacks are removed in gdbm-1_8_3-5_fc14. When building and pushing compat-gdbm into rawhide, gdbm-1_8_3-5_fc14 should also be built, and the packages should land into rawhide together. Rex, thank you for the review. New Package CVS Request ======================= Package Name: compat-gdbm Short Description: A GNU set of database routines compatibility library Owners: kklic Branches: devel InitialCC: CVS done (by process-cvs-requests.py). |