Bug 573525 (perl-opts)

Summary: Review Request: perl-opts - Simple command line option parser
Product: [Fedora] Fedora Reporter: Chris Weyl <cweyl>
Component: Package ReviewAssignee: Marcela Mašláňová <mmaslano>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: mmaslano: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/opts
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-19 23:51:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Chris Weyl 2010-03-15 04:07:01 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-opts.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-opts-0.022-1.fc12.src.rpm

Description:
opts is a DSL for quickly and easily handling command line options.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2052579

*rt-0.10_01

Comment 1 Marcela Mašláňová 2010-03-19 14:26:56 UTC
OK rpmlint on every package.
OK name of package accords to the Naming Guidelines.
OK spec file name match the base package %{name}.
   08293bb9013c18f91fa4307feadb0102
OK package meet the Packaging Guidelines.
OK package has a good license.
OK spec file is written in American English.
OK spec file for the package must be legible.
OK The sources used to build the package must match the upstream source.
OK successful koji compilation.
OK correct BuildRequires, Requires.
OK proper use of %find_lang macro.
OK shared library must call ldconfig in %post and %postun.
OK relocatable package must state this fact.
OK package must own their directories.
OK permissions on files must be set properly.
OK %clean section with rm -rf %{buildroot}.
OK consistent use of macros.
OK package contains code, or permissable content.
OK large documentation go in a -doc subpackage.
OK %doc must not affect the runtime of the application.
OK header files must be in a -devel package.
OK static libraries must be in a -static package.
OK pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK library files with a suffix (.so) must go in -devel.
OK usually devel packages must require the base package.
OK Remove .la libtool archives.
OK GUI applications must include a %{name}.desktop file.
OK %install section starts with rm -rf %{buildroot}.

ACCEPT

Comment 2 Chris Weyl 2010-03-19 15:47:23 UTC
New Package CVS Request
=======================
Package Name: perl-opts
Short Description: Simple command line option parser
Owners: cweyl
Branches: F-11 F-12 F-13 devel
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2010-03-19 19:59:03 UTC
CVS done (by process-cvs-requests.py).

Comment 4 Chris Weyl 2010-03-19 23:51:19 UTC
Thanks for the review! :-)