Bug 57353

Summary:	source code problems
Product:	[Retired] Red Hat Linux	Reporter:	d.binderman
Component:	usermode	Assignee:	Jindrich Novy <jnovy>
Status:	CLOSED CURRENTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	low	Docs Contact:
Priority:	medium
Version:	7.1	CC:	pknirsch
Target Milestone:	---
Target Release:	---
Hardware:	alpha
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-09-30 00:39:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description d.binderman 2001-12-10 18:40:00 UTC

From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD NetscapeOnline.co.uk  (Win98; I)

Description of problem:

In compiling package usermode-1.42-1 from RedHat 7.1,
I got the following message from the compiler

1.

cc: Warning: consolehelper.c, line 82: In this statement, the expression "constructed_argv[cargc+cdiff]=argv[cargc++]" modifies "cargc", 
and fetches its value in a computation that is not used to produce the modified value without an intervening sequence point.  This behavior 
is undefined. (undefvarfetch)
  for (cargc = 1; cargc < argc; constructed_argv[cargc+cdiff] = argv[cargc++]);
--------------------------------^

maybe something like

  for (cargc = 1; cargc < argc; )
  {
	constructed_argv[ cargc + cdiff] = argv[ cargc];
	++cargc;
  }

would be better.



Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. compiler with Compaq C compiler and flag -w0
2.
3.
	

Additional info:

Comment 1 Miloslav Trmač 2004-09-30 00:39:54 UTC

Thanks for your report, this is fixed in current version.