Bug 573929
| Summary: | Review Request: perl-Compress-Raw-Zlib - Low-Level Interface to zlib compression library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Mark Chappell <tremble> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cweyl, dcantrell, fedora-package-review, iarnell, notting, rdieter, tremble |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | tremble:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-10 11:04:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 573932 | ||
|
Description
Marcela Mašláňová
2010-03-16 08:45:00 UTC
This one is bundling a private copy of zlib. It needs the same BUILD_ZLIB=False stuff the previous spec had.
I don't think we need the comment in description about where to get zlib, either.
And maybe use %{?perl_default_filter} to avoid providing Zlib.so().
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format %{name}.spec.
[!] Package meets the Packaging Guidelines including the Perl specific items
* Looks like a bundled ZLib
[x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2056653
[x] Rpmlint output:
vampire:~ $ rpmlint perl-Compress-Raw-Zlib-*
perl-Compress-Raw-Zlib.src: E: specfile-error sh: line 1: fg: no job control
perl-Compress-Raw-Zlib.src: E: specfile-error sh: line 1: fg: no job control
3 packages and 0 specfiles checked; 2 errors, 0 warnings.
*These are fine*
[x] Package is not relocatable.
[x] Buildroot is correct
Buildroot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided in the spec URL.
5b637dbb36955b13db261f049fe529d9 Compress-Raw-Zlib-2.024.tar.gz
5b637dbb36955b13db261f049fe529d9 Compress-Raw-Zlib-2.024.tar.gz.1
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
[!] Package consistently uses macros.
[x] Package contains code, or permissable content.
[x] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2056654
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: fedora-rawhide-x86_64 and fedora-rawhide-i686
[-] Package functions as described.
[-] Scriptlets must be sane, if used.
[] The placement of pkgconfig(.pc) files is correct.
[] File based requires are sane.
[x] %check is present and the tests pass
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/000prereq.t ...... ok
t/01version.t ...... ok
t/02zlib.t ......... ok
t/07bufsize.t ...... ok
t/09limitoutput.t .. ok
t/18lvalue.t ....... ok
t/99pod.t .......... skipped: Test::Pod 1.00 required for testing POD
All tests successful.
Files=7, Tests=699, 3 wallclock secs ( 0.11 usr 0.06 sys + 2.14 cusr 0.16 csys = 2.47 CPU)
Result: PASS
===
Couple of issues,
* Looks like it's using the bundled zlib, see the README for details on how to avoid this http://cpansearch.perl.org/src/PMQS/Compress-Raw-Zlib-2.024/README
* You're using $RPM_BUILD_ROOT and $RPM_OPT_FLAGS where the rest of the time you're using %{} macros this feels wrong, but is probably okay...
(In reply to comment #1) > And maybe use %{?perl_default_filter} to avoid providing Zlib.so(). Yep -- this should be done, and is safe to do in the independent subpackages. I merged the old spec file from F-8, which fixed mentioned issues. The Zlib.so has been filtered. Probably I should obsoletes this sub-package in perl.spec. New version: http://mmaslano.fedorapeople.org/review/perl-Compress-Raw-Zlib-2.024-2.fc14.src.rpm http://mmaslano.fedorapeople.org/review/perl-Compress-Raw-Zlib.spec $ rpmlint perl-Compress-Raw-Zlib-2.024-2.fc14.*.rpm perl-Compress-Raw-Zlib.src: E: specfile-error sh: line 1: fg: no job control perl-Compress-Raw-Zlib.src: E: specfile-error sh: line 1: fg: no job control perl-Compress-Raw-Zlib.src: E: specfile-error sh: line 1: fg: no job control 2 packages and 0 specfiles checked; 3 errors, 0 warnings. Logs show it's no longer building it's own zlib http://koji.fedoraproject.org/koji/getfile?taskID=2059728 APPROVED Thanks for review. I don't see from rpmlint in F-13 these warnings. New Package CVS Request ======================= Package Name: perl-Compress-Raw-Zlib Short Description: Low-Level Interface to zlib compression library Owners: mmaslano Branches: F-13 InitialCC: perl-sig This package already seems to be in fedora. ;) https://admin.fedoraproject.org/pkgdb/acls/name/perl-Compress-Raw-Zlib This package was dead, now it's needed again as separeted package. Sadly Fedora pkgdb show even branches, where the package was dead, which is not comprehensible. I still need F-13 branch. Could you add it please? New Package CVS Request ======================= Package Name: perl-Compress-Raw-Zlib Short Description: Low-Level Interface to zlib compression library Owners: mmaslano Branches: F-13 InitialCC: perl-sig And also for devel branch as I unsuccessfully tried :) Odd, I see this package being owned by you in all of F-11/F-12/F-13/devel branches. What issue are you seeing exactly? Ah. I think I see the problem. Try now? http://koji.fedoraproject.org/koji/taskinfo?taskID=2086189 F-13 the same problem http://koji.fedoraproject.org/koji/taskinfo?taskID=2086203 You can also notice that I can't set all permission in package database even if I'm a proven packager see https://admin.fedoraproject.org/pkgdb/acls/name/perl-Compress-Raw-Zlib?_csrf_token=5bd4b080cc97e953ac5b0ed297d050912298a00a The package is still tag as dead and I can't remove it. What should I do next? I removed dead.package from cvs. The problem is that package is blocked in collection: BuildError: package perl-Compress-Raw-Zlib is blocked for tag dist-f14 The "blocking" is a part of retiring packages in howto "the package to be blocked from the appropriate collections in which it is retired". Therefore you should unblock it somewhere. BuildError: package perl-Compress-Raw-Zlib is blocked for tag dist-f14 IIRC that means it's blocked in koji, you'll need to speak to rel-eng. (can't remember how to list the blocked packages outside of postgres) You need to file a ticket with rel-eng to get it unblocked. https://fedorahosted.org/rel-eng/newticket Looks like there are some F-13 and F-14 builds now in koji, should this bug be closed? Good point, thanks. Bringing this package in should have resulted in removing the perl-Compress-Raw-Zlib subpackage of the base perl package, but that has not happened. This is causing some issues with trying to use Fedora as an external repo in Koji, as there are now two different perl-Compress-Raw-Zlib packages with different srpm versions and koji doesn't like that at all. Please clean up the base perl package ore re-block this one. We created two packages on purpose. From rpm side it should work and we didn't think about koji. Could you be more specific about those koji problems? We have more packages than this one, which live their dual lifes. Upon closer look, there may not actually be a problem with this package in particular. Koji looks at the srpm for each package it sees in all the repos added, and will only take packages that come from the newest srpm if there are multiple. Because secondary arches are a bit behind koji, I'm running into a situation where we have newer and older packages that are coming from the same named srpm and I have to sort them out accordingly. Something is throwing perl for a loop and I thought it was this, because there were multiple in the same repo, but the srpm names don't match, so this may not actually be a problem. I'm doing more investigation. What is the reason for having multiple of the same? Marcela, you need to rename one of these. there are a few issues here. 1 is that you can only ever install one of these, whichever is the highest nvr will always be chosen, 2 is that koji only ever allows you to have a rpm with a single nvra once so if perl starts to provide a version thats already existed seperatly you will not be able to build perl or vice versa. i do not know what this dual life thing your talking about is suppose dto mean, but yum and rpm will only let you install a single version of a package name unless specifically configured otherwise like the kernel is. i suspect that things do not work however your thinking that they should be. Dennis, we only want to install one of these. Effectively, perl-Compress-Raw-Zlib has two separate upstreams: perl and cpan. Sometimes perl has the latest version, and sometimes cpan. We simply want to be able to have the latest package available in fedora without having to continually block/unblock this package - the history here shows how troublesome that was to do just once. We've had several dual-life packages for over a year now and things are working exactly as we expect them to on our end. And we're unlikely to run into duplicate nvras since we're already stuck with ever increasing release numbers in the perl package. perl-Compress-Raw-Zlib-2.037-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Compress-Raw-Zlib-2.037-4.fc16 perl-CPAN-Meta-YAML-0.003-7.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-CPAN-Meta-YAML-0.003-7.fc16 perl-Perl-OSType-1.002-7.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Perl-OSType-1.002-7.fc16 perl-Test-Simple-0.98-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Test-Simple-0.98-3.fc16 perl-version-0.88-6.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-version-0.88-6.fc16 perl-threads-1.83-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-threads-1.83-4.fc16 perl-threads-shared-1.37-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-threads-shared-1.37-3.fc16 perl-parent-0.225-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-parent-0.225-4.fc16 perl-Perl-OSType-1.002-7.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. perl-Compress-Raw-Zlib-2.037-4.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. perl-threads-shared-1.37-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. perl-Test-Simple-0.98-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. perl-parent-0.225-4.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. perl-CPAN-Meta-YAML-0.003-7.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. perl-version-0.88-6.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. perl-threads-1.83-4.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |