Bug 574662
Summary: | Review Request: perl-CDDB - CDDB Perl module | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jan Klepek <jan.klepek> |
Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | perl-CDDB-1.220-3.fc13 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-04-09 01:32:57 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jan Klepek
2010-03-18 06:24:55 UTC
OK rpmlint on every package. OK name of package accords to the Naming Guidelines. OK spec file name match the base package %{name}. 56e0ba3f347e1b14f41f340f0cb3be3a OK package meet the Packaging Guidelines. OK package has a good license. OK spec file is written in American English. OK spec file for the package must be legible. OK The sources used to build the package must match the upstream source. OK successful koji compilation. OK correct BuildRequires, Requires. OK proper use of %find_lang macro. OK shared library must call ldconfig in %post and %postun. OK relocatable package must state this fact. OK package must own their directories. OK permissions on files must be set properly. OK %clean section with rm -rf %{buildroot}. OK consistent use of macros. OK package contains code, or permissable content. OK large documentation go in a -doc subpackage. OK %doc must not affect the runtime of the application. OK header files must be in a -devel package. OK static libraries must be in a -static package. OK pkgconfig(.pc) files must 'Requires: pkgconfig'. OK library files with a suffix (.so) must go in -devel. OK usually devel packages must require the base package. OK Remove .la libtool archives. OK GUI applications must include a %{name}.desktop file. OK %install section starts with rm -rf %{buildroot}. For review is needed: - replacement: s/PERL_INSTALL_ROOT/DESTDIR/ - removal: R: Test::More. I suppose module doesn't need test suite for functionality. fixed in Spec URL: http://hpejakle.fedorapeople.org/packages/perl-CDDB.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/perl-CDDB-1.220-3.fc11.src.rpm Great, accepted New Package CVS Request ======================= Package Name: perl-CDDB Short Description: CDDB Perl module Owners: hpejakle Branches: F-11 F-12 F-13 InitialCC: perl-sig CVS done (by process-cvs-requests.py). perl-CDDB-1.220-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-CDDB-1.220-3.fc12 perl-CDDB-1.220-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-CDDB-1.220-3.fc13 perl-CDDB-1.220-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-CDDB-1.220-3.fc11 perl-CDDB-1.220-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CDDB'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-CDDB-1.220-3.fc12 perl-CDDB-1.220-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CDDB'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-CDDB-1.220-3.fc11 perl-CDDB-1.220-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CDDB'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-CDDB-1.220-3.fc13 perl-CDDB-1.220-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. perl-CDDB-1.220-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. perl-CDDB-1.220-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |