Bug 575822
| Summary: | Review Request: bacula2 - Backup client for bacula version 2 server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
| Component: | Package Review | Assignee: | Neil Horman <nhorman> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, fschwarz, nhorman, notting |
| Target Milestone: | --- | Flags: | nhorman:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | bacula2-2.4.4-4.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-04-21 21:52:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 552263 | ||
|
Description
Gwyn Ciesla
2010-03-22 13:55:46 UTC
rpmlint results
[nhorman@hmsreliant Download]$ rpmlint ./bacula2-2.4.4-4.fc12.src.rpm
bacula2.src: W: spelling-error Summary(en_US) bacula -> Dracula, backlash, oracular
bacula2.src: W: spelling-error %description -l en_US Bacula -> Dracula, Backlash, Oracular
bacula2.src: W: spelling-error %description -l en_US bacula -> Dracula, backlash, oracular
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Spelling errors are prettly clearly confusion on the part of rpmlint, so waive those.
Naming: check. follows guidelines
Spec File:
Legible, american english, Good.
Looks like you need tcp_wrappers-devel added as a BuildRequires
also, it looks like you use the macro %{__initrddir} and I don't see where that is defined. Of course it builds fine, so I'm guessing I'm just missing something
Initscript looks good
The BuildRoot tag isn't needed anymore, but its ignored and correct if it were to be used, so don't worry about it
License is ok (GPLv2 with exceptions), and included as %doc
upstream sources match (4eb6155b45611018af03002d37a2ffde)
Package Builds: check on x86_64
No DSO's in package, so we're good there
No devel package
No static libraries
No double owned directories or files, check.
install does a rm -rf %buildroot, check
spec if utf-8, check
builds in mock, check (after adding tcp_wrappers-devel to Buildrequires)
subpackage client requires fully versioned common package, check
I think if you fix the tcpwrappers issue (and explain the initrddir macro to me), I'll approve this, thanks!
There is a BR for /usr/include/tcpd.h on line 34 which covers this. It's inherited from the main Bacula RPM, which does it this way because the file is in tcp_wrappers on some releases and tcp_wrappers-devel on others.
%{_initrddir} is an internal rpm macro. Try rpm --eval %{_initrddir} to see for yourself. On F-12 it gives /etc/rc.d/init.d.
ok, thanks. For the record, it seems that the right fix for tcpd.h should be to harp on the EPEL and Fedora maintainer to put it in the -devel pacakge consistently, but I think the solution you have is fine, given that changing file locations mid-release (for EPEL at least is real pain in the rear). ok, ACK to this package, go ahead and request CVS branch creation when you're ready. Thanks! Thanks! New Package CVS Request ======================= Package Name: bacula2 Short Description: Backup client for bacula version 2 server Owners: limb Branches: F-13 F-12 InitialCC: CVS done (by process-cvs-requests.py). bacula2-2.4.4-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/bacula2-2.4.4-4.fc13 bacula2-2.4.4-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/bacula2-2.4.4-4.fc12 bacula2-2.4.4-4.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bacula2'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/bacula2-2.4.4-4.fc13 bacula2-2.4.4-4.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bacula2'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/bacula2-2.4.4-4.fc12 bacula2-2.4.4-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. bacula2-2.4.4-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |