Bug 576153
| Summary: | Review Request: gnome-icon-theme-extras - Additional GNOME icons | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bastien Nocera <bnocera> |
| Component: | Package Review | Assignee: | Benjamin Otte <otte> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, otte |
| Target Milestone: | --- | Flags: | otte:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | gnome-icon-theme-extras-2.29.0-4.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-04-09 04:03:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Bastien Nocera
2010-03-23 12:28:03 UTC
Note that the tarball isn't upstream yet, but we'll be using a real release tarball as soon as it comes out, and before uploading this package to Fedora. Updated SRPM and spec: http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-theme-extras-2.29.0-2.fc12.src.rpm http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-theme-extras.spec With some scriptlets fixes. And with the proper release tarball: http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-theme-extras.spec http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-theme-extras-2.29.0-3.fc12.src.rpm I'm taking this review. $ rpmlint gnome-icon-theme-extras.spec gnome-icon-theme-extras.spec: W: no-buildroot-tag 0 packages and 1 specfiles checked; 0 errors, 1 warnings. That warning can be ignored due to the new rules. => OK Koji builds it fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=2077560 => OK Looking at the ReviewGuidelines, everything looks fine, apart from MUST: The License field in the package spec file must match the actual license spec file says GPL, actual license is CC-BY-SA-3.0 => NOT OK So with the lixense fixed, the package looks fine. License tag fixed in: http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-theme-extras-2.29.0-4.fc12.src.rpm http://people.fedoraproject.org/~hadess/gnome-icon-theme-extras/gnome-icon-theme-extras.spec Note that the short name doesn't include the version: https://fedoraproject.org/wiki/Licensing Yeah, I noticed already that CC licenses don't have a version in Fedora. Weird thing that. WIth that fixed, the package is accepted. New Package CVS Request ======================= Package Name: gnome-icon-theme-extras Short Description: Additional GNOME icons Owners: hadess Branches: F-12 F-13 devel InitialCC: CVS done (by process-cvs-requests.py). gnome-icon-theme-extras-2.29.0-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/gnome-icon-theme-extras-2.29.0-4.fc13 gnome-icon-theme-extras-2.29.0-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |