Bug 576757 (moovida-plugins-good)

Closing this as the master moovida package review bug 554243 has been marked as a dead review.

Graeme, I would love to see mooodiva in Fedora, so if you're still interested in packaging up moovida and getting this into Fedora, feel free to re-open. And I'll try to help you sort out any technical issues and sponsor you.

Regards,

Hans

Hi,

I have fixed a couple of outstanding issues with this package including changing the %excludes to be removed during %install instead, and getting rid of the duplicate file errors, and now have new packages for review

moovida-plugins-good.spec
http://ggillies.fedorapeople.org/moovida-plugins-good.spec

moovida-plugins-good-1.0.9-3.fc13.src.rpm
http://ggillies.fedorapeople.org/moovida-plugins-good-1.0.9-3.fc13.src.rpm

As I offered in the -bad and -good plugins reviews I'll review this and when that is done sponsor you. I hope to finish reviewing at least the base package today before my short vacation.

Hi,

Sorry for the long delay. I recently switched teams with in Red Hat and as such have been overwhelmed with work a bit. Here is a full review of this package:

Full review:

Good:
- rpmlint checks return:
moovida-plugins-good.noarch: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
These can all be ignored
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3) OK, text not %doc, but also not in upstream tarbal, so no
  problem,  matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime

Approved!

New Package SCM Request
=======================
Package Name: moovida-plugins-good
Short Description: This package contains a collection of well-supported plug-ins of good quality and under the LGPL license for the Moovida media centre.
Owners: ggillies
Branches: f13 f14
InitialCC:

Git done (by process-git-requests).

moovida-plugins-bad-1.0.9-3.fc14,moovida-plugins-good-1.0.9-3.fc14,moovida-1.0.9-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/moovida-plugins-bad-1.0.9-3.fc14,moovida-plugins-good-1.0.9-3.fc14,moovida-1.0.9-3.fc14

moovida-plugins-bad-1.0.9-3.fc13,moovida-plugins-good-1.0.9-3.fc13,moovida-1.0.9-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/moovida-plugins-bad-1.0.9-3.fc13,moovida-plugins-good-1.0.9-3.fc13,moovida-1.0.9-3.fc13

moovida-plugins-bad-1.0.9-3.fc14, moovida-plugins-good-1.0.9-3.fc14, moovida-1.0.9-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update moovida-plugins-bad moovida-plugins-good moovida'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/moovida-plugins-bad-1.0.9-3.fc14,moovida-plugins-good-1.0.9-3.fc14,moovida-1.0.9-3.fc14

moovida-plugins-bad-1.0.9-3.fc14, moovida-plugins-good-1.0.9-3.fc14, moovida-1.0.9-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

moovida-plugins-bad-1.0.9-3.fc13, moovida-plugins-good-1.0.9-3.fc13, moovida-1.0.9-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.