Bug 577514

Summary:	Review Request: luarocks - Package management system for Lua modules
Product:	[Fedora] Fedora	Reporter:	Duboucher Thomas <thomas>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, michel, notting
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	NotReady
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-05-08 14:05:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Duboucher Thomas 2010-03-27 18:19:39 UTC

I found out that LuaRocks wasn't available on Fedora, so I tried to package it during my spare time. However, I'm still having some issues that I don't exactly know how to handle properly.

Spec URL: http://thomas.duboucher.free.fr/luarocks.spec
SRPM URL: http://thomas.duboucher.free.fr/luarocks-2.0.1-1.fc12.src.rpm

Result of rpmlint on .spec, .rpm and .src.rpm:
luarocks.spec:70: W: configure-without-libdir-spec
luarocks.x86_64: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsus
luarocks.x86_64: W: spelling-error %description -l en_US devel -> delve, devil, revel
luarocks.x86_64: E: no-binary
luarocks.x86_64: W: only-non-binary-in-usr-lib
luarocks.x86_64: W: dangling-symlink /usr/lib/lua/5.1 /usr/lib64/lua/5.1
luarocks.src: W: spelling-error %description -l en_US metadata -> meta data, meta-data, metatarsus
luarocks.src: W: spelling-error %description -l en_US lua -> la, luau, lea
luarocks.src: W: spelling-error %description -l en_US devel -> delve, devil, revel
luarocks.src:70: W: configure-without-libdir-spec
2 packages and 1 specfiles checked; 1 errors, 9 warnings.

Here is a list of the main issues I still have.
* One of the main problems is LuaRocks being no-arch (since it is plain Lua), but still being arch dependant since it compiles Lua modules written in C.
* Also, packages installed with LuaRocks _do_ collide with Lua packages available as RPM, such as luadoc, in /usr/lib/lua/5.1/.
* On x86_64, LuaRocks installs packages under /usr/lib/lua/5.1/, but Lua searches for its packages under /usr/lib64/lua/5.1/. I fixed this issue with a symlink.

The package works well under Fedora 12 x86_64, but I haven't tested it under i686.

Thanks in advance.

Comment 1 Jason Tibbitts 2010-12-03 16:04:21 UTC

I'm trying to locate someone who understands lua sufficiently to look at this package.  I'm pretty sure that some of the issues make this package unacceptable as is (conflicting with existing packages and the x86_64 thing needing a symlink) but I have essentially no understanding of lua issues so I can't say for sure.

If I do manage to find someone who wants to is willing to review this, are you still interested in submitting it?

Comment 2 Duboucher Thomas 2010-12-05 13:30:05 UTC

Thanks for having a look at this issue. I am very busy at the moment and I will have little time to dedicate.
I originaly made the package and the following request when I noticed that Lua was missing its package manager in Fedora so that if anyone would want to use it he or she can find the request.

Actually, I think the best for me would be to wait until I get more spare time; I will then update the request for Fedora 14-15 and fix issue #2 and #3.

Comment 3 Michel Lind 2012-05-08 11:36:05 UTC

Hi Thomas,

The Lua package maintainers (mostly Tim Niemuller and myself) have been mulling having better luarocks integration for a while. Are you still interested in maintaining this?

I've just submitted an updated spec here: https://bugzilla.redhat.com/show_bug.cgi?id=819844

the issues that existed in previous releases seem to be fixed; the only problem now is that luarocks is currently not ready for Lua 5.2 yet (though we're not currently planning to move for the time being)

Let me know if you're interested -- if you want to be primary maintainer, we can continue the discussion here, if not (say you want to comaintain), we can continue on the newer request. Thanks!

Comment 4 Duboucher Thomas 2012-05-08 12:58:31 UTC

Hi Michel,

I haven't used Fedora or Lua/Luarocks for a while now. :)

You can close this review as it is outdated and go on with the newer specfile.

Comment 5 Michel Lind 2012-05-08 14:05:14 UTC

Hi Thomas,

Thanks for confirming -- but sorry to hear you're no longer with both communities. Hope to see you back in the future!

*** This bug has been marked as a duplicate of bug 819844 ***