Bug 577983

Summary: tuned: AttributeError: Nettool instance has no attribute 'interface'
Product: [Fedora] Fedora Reporter: Marcus Alves Grando <marcus>
Component: tunedAssignee: Jan Vcelak <jvcelak>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: low    
Version: 12CC: jvcelak, mmaslano, pknirsch, plautrba, tsmetana, twoerner
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: tuned-0.2.12-1.fc12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 578104 (view as bug list) Environment:
Last Closed: 2010-04-20 13:08:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 578104    
Attachments:
Description Flags
Patch none

Description Marcus Alves Grando 2010-03-29 22:00:36 UTC
Created attachment 403372 [details]
Patch

tuned using wrong attribute:

[18:38:38] marcus@sup-afu:~$ sudo tuned
2010-03-29 18:38:46,864 INFO     tuned.cpumonitor: Module is enabled
2010-03-29 18:38:46,868 INFO     tuned.diskmonitor: Module is enabled
2010-03-29 18:38:46,869 INFO     tuned.diskmonitor: Available hard drives: sda
2010-03-29 18:38:46,869 INFO     tuned.netmonitor: Module is enabled
2010-03-29 18:38:46,869 INFO     tuned.netmonitor: Available ethernet cards: eth0.110, eth0.203, eth0
2010-03-29 18:38:46,869 INFO     tuned.cputuning: Module is enabled
2010-03-29 18:38:46,869 INFO     tuned.disktuning: Module is enabled
2010-03-29 18:38:46,869 INFO     tuned.nettuning: Module is enabled
2010-03-29 18:38:46,869 INFO     tuned: Running...
Traceback (most recent call last):
  File "/usr/sbin/tuned", line 101, in <module>
    tuned.run()
  File "/usr/share/tuned/tuned.py", line 108, in run
    p.setTuning(lh)
  File "/usr/share/tuned/tuningplugins/net.py", line 71, in setTuning
    ethcard(dev).set_speed(100) # FIXME: what about making this more dynamic?
  File "/usr/share/tuned/tuned_nettool.py", line 118, in set_speed
    log.debug("%s: set_speed(%d) - effective_mode 0x%03x" % (self.interface, speed, effective_mode))
AttributeError: Nettool instance has no attribute 'interface'
2010-03-29 18:39:36,918 INFO     tuned: Cleaning up...

Fix attched.

Best regards

Comment 1 Jan Vcelak 2010-03-30 08:26:32 UTC
Hi,

thank you for your report and as well for the fix.

I've fixed it in upstream repository. And I will make an update in Fedora as soon as possible.

Jan

Comment 2 Jan Vcelak 2010-03-30 14:01:20 UTC
Fixed in F12, F13, Rawhide.

Comment 3 Fedora Update System 2010-03-30 14:02:27 UTC
tuned-0.2.12-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/tuned-0.2.12-1.fc13

Comment 4 Fedora Update System 2010-03-30 14:02:47 UTC
tuned-0.2.12-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/tuned-0.2.12-1.fc12

Comment 5 Fedora Update System 2010-04-01 01:55:44 UTC
tuned-0.2.12-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update tuned'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/tuned-0.2.12-1.fc12

Comment 6 Fedora Update System 2010-04-09 04:12:10 UTC
tuned-0.2.12-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2010-04-20 13:07:56 UTC
tuned-0.2.12-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.