Bug 579060
| Summary: | Review Request: perl-String-Formatter - Build sprintf-like functions of your own | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | cweyl:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/String-Formatter/ | ||
| Whiteboard: | |||
| Fixed In Version: | perl-String-Formatter-0.100720-1.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-04-20 12:59:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Iain Arnell
2010-04-02 12:16:46 UTC
Looks good!
Your sed syntax is interesting: "sed -i -e '1s~#!perl~#!%{__perl}~' bench.pl".
Am I correct in thinking the leading "1" constrains sed to tinkering with the
first line only? Or only one match?
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2091038
Spec looks sane, clean and consistent; license is correct (GPLv2);
make test passes cleanly.
Source tarballs match upstream (sha1sum):
4ff6a1d173c7f51ef794a8c9d63e6e17a60f62d0 String-Formatter-0.100720.tar.gz
4ff6a1d173c7f51ef794a8c9d63e6e17a60f62d0 String-Formatter-0.100720.tar.gz.srpm
Final provides / requires are sane:
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-String-Formatter-0.100720-1.fc14.noarch.rpm <=====
====> rpmlint
perl-String-Formatter.noarch: W: spelling-error Summary(en_US) sprintf -> sprint, sprints, sprint f
perl-String-Formatter.noarch: W: spelling-error %description -l en_US sprintf -> sprint, sprints, sprint f
perl-String-Formatter.noarch: W: spelling-error %description -l en_US expanders -> ex panders, ex-panders, expands
perl-String-Formatter.noarch: W: spelling-error %description -l en_US formatters -> for matters, for-matters, formatted
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
====> provides for perl-String-Formatter-0.100720-1.fc14.noarch.rpm
perl(String::Formatter) = 0.100720
perl-String-Formatter = 0.100720-1.fc14
perl(String::Formatter::Cookbook) = 0.100720
====> requires for perl-String-Formatter-0.100720-1.fc14.noarch.rpm
perl >= 0:5.006
perl(:MODULE_COMPAT_5.10.1)
perl(Params::Util)
perl(strict)
perl(Sub::Exporter)
perl(warnings)
=====> perl-String-Formatter-0.100720-1.fc14.src.rpm <=====
====> rpmlint
perl-String-Formatter.src: W: spelling-error Summary(en_US) sprintf -> sprint, sprints, sprint f
perl-String-Formatter.src: W: spelling-error %description -l en_US sprintf -> sprint, sprints, sprint f
perl-String-Formatter.src: W: spelling-error %description -l en_US expanders -> ex panders, ex-panders, expands
perl-String-Formatter.src: W: spelling-error %description -l en_US formatters -> for matters, for-matters, formatted
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
====> provides for perl-String-Formatter-0.100720-1.fc14.src.rpm
====> requires for perl-String-Formatter-0.100720-1.fc14.src.rpm
perl >= 0:5.006
perl(ExtUtils::MakeMaker)
perl(Params::Util)
perl(Pod::Coverage::TrustPod)
perl(Sub::Exporter)
perl(Test::More)
perl(Test::Pod)
perl(Test::Pod::Coverage)
APPROVED
Thanks, Chris. Yes, the leading "1" is an address that restricts the "s" command to the first line. New Package CVS Request ======================= Package Name: perl-String-Formatter Short Description: Build sprintf-like functions of your own Owners: iarnell Branches: F-11 F-12 F-13 InitialCC: perl-sig CVS done (by process-cvs-requests.py). perl-String-Formatter-0.100720-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc12 perl-String-Formatter-0.100720-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc11 perl-String-Formatter-0.100720-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc13 perl-String-Formatter-0.100720-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Formatter'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc13 perl-String-Formatter-0.100720-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Formatter'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc12 perl-String-Formatter-0.100720-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-String-Formatter'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-String-Formatter-0.100720-1.fc11 perl-String-Formatter-0.100720-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. perl-String-Formatter-0.100720-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. perl-String-Formatter-0.100720-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |