Bug 579327
| Summary: | Review Request: perl-Perl-PrereqScanner - Tool to scan your Perl code for its prerequisites | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Perl-PrereqScanner/ | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Perl-PrereqScanner-0.100960-1.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-04-30 23:39:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 579061 | ||
| Bug Blocks: | |||
|
Description
Iain Arnell
2010-04-04 08:21:22 UTC
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2093995 + rpmlint is silent for SRPM and for RPM. perl-Perl-PrereqScanner.noarch: I: checking-url http://search.cpan.org/dist/Perl-PrereqScanner/ (timeout 10 seconds) perl-Perl-PrereqScanner.src: I: checking-url http://search.cpan.org/dist/Perl-PrereqScanner/ (timeout 10 seconds) perl-Perl-PrereqScanner.src: I: checking-url http://www.cpan.org/authors/id/J/JQ/JQUELIN/Perl-PrereqScanner-0.100830.tar.gz (timeout 10 seconds) 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + source files match upstream url (sha1sum) aef5256d1e54b2ccbeef1e40ce635616fc5b1fe5 Perl-PrereqScanner-0.100830.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=72, 0 wallclock secs ( 0.02 usr 0.02 sys + 0.43 cusr 0.06 csys = 0.53 CPU) + Package perl-Perl-PrereqScanner-0.100830-1.fc14.noarch => Provides: perl(Perl::PrereqScanner) = 0.100830 Requires: perl >= 0:5.008 perl(File::Spec::Functions) perl(FindBin) perl(lib) perl(List::Util) perl(namespace::autoclean) perl(Perl::PrereqScanner) perl(PPI) >= 1.205 perl(Scalar::Util) perl(strict) perl(Version::Requirements) >= 0.100630 perl(warnings) rpmlib(VersionedDependencies) <= 3.0.3-1 /usr/bin/perl + Not a GUI application Suggestions: 1) Remove following from SPEC BuildRequires: perl >= 0:5.008 2) Also, I think following can be removed BuildRequires: perl(PPI::Document) as following is already included BuildRequires: perl(PPI) >= 1.205 APPROVED. New Package CVS Request ======================= Package Name: perl-Perl-PrereqScanner Short Description: Tool to scan your Perl code for its prerequisites Owners: iarnell Branches: F-11 F-12 F-13 InitialCC: perl-sig CVS done (by process-cvs-requests.py). Thanks for the review. I've dropped the perl BR, but left PPI::Document. Built in rawhide; waiting for perl-Version-Requirements on branches. perl-Perl-PrereqScanner-0.100960-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Perl-PrereqScanner-0.100960-1.fc13 perl-Perl-PrereqScanner-0.100960-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Perl-PrereqScanner'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/perl-Perl-PrereqScanner-0.100960-1.fc13 perl-Perl-PrereqScanner-0.100960-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |