Bug 579369
Summary: | Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc... | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | René Ribaud <rene.ribaud> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, fonts-bugs, mtasaka, notting, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | kanjistrokeorders-fonts-2.014-4.fc12 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-05-24 19:38:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
René Ribaud
2010-04-04 17:05:53 UTC
(Removing NEEDSPONSOR) sorry I am busy with some other work. Will review this tomorrow. Hi Parag, First thanks to assigned you this review. No worries, I can wait. This package is not an urgent one, so just take all the time you need. Best regards. René. Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2171526 + rpmlint is silent for SRPM and for RPM. kanjistrokeorders-fonts.src: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur, Kansas kanjistrokeorders-fonts.noarch: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur, Kansas 2 packages and 0 specfiles checked; 0 errors, 2 warnings. + source files match upstream url (sha1sum) ba3a6a7904431c0969f196d2b2915ef6c87cff47 KanjiStrokeOrders_v2.014.zip there is no direct download url working using wget though. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Follow fonts packaging guidelines. Suggestions: 1) remove following comments from SPEC #ln -s /dev/null \ # %{buildroot}%{_fontconfig_confdir}/%{fontconf} 2) Give newline after each changelog entry and also between BuildRequires: line and %description line 3) Instead of adding BuildRequires: dos2unix, you can do following in %prep. ========================================================== for file in copyright.txt readme_en_v2.014.txt; do sed "s|\r||g" $file > $file.new && \ touch -r $file $file.new && \ mv $file.new $file done =========================================================== This will help not to increase build time dependency on dos2unix package. Hi Parag, Thanks for the review, I have fixed the package. > Suggestions: > 1) remove following comments from SPEC > #ln -s /dev/null \ > # %{buildroot}%{_fontconfig_confdir}/%{fontconf} Removed > > 2) Give newline after each changelog entry and also between BuildRequires: line > and %description line > Done > 3) Instead of adding BuildRequires: dos2unix, you can do following in %prep. > ========================================================== > for file in copyright.txt readme_en_v2.014.txt; do > sed "s|\r||g" $file > $file.new && \ > touch -r $file $file.new && \ > mv $file.new $file > done > =========================================================== > > This will help not to increase build time dependency on dos2unix package. Done, I used "sed -i" instead of dos2unix. Anyway we will find the updated package here : Spec URL: http://uggla.free.fr/rpmbuild/SPECS/kanjistrokeorders-fonts.spec SRPM URL: http://uggla.free.fr/rpmbuild/SRPMS/12/kanjistrokeorders-fonts-2.014-4.fc12.src.rpm RPMLINT output : ---------------- [ctb@uggla SRPMS]$ rpmlint kanjistrokeorders-fonts-2.014-4.fc12.src.rpm kanjistrokeorders-fonts.src: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur, Kansas 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [ctb@uggla noarch]$ rpmlint kanjistrokeorders-fonts-2.014-4.fc12.noarch.rpm kanjistrokeorders-fonts.noarch: W: spelling-error %description -l en_US kanji -> Kantian, Kanpur, Kansas 1 packages and 0 specfiles checked; 0 errors, 1 warnings. KOJI output : ------------- I have built the package with koji on all architectures for F12, F13 and rawhide. You can look at the F12 result here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2186156 F13 here : and F14 here : Waiting for your feedbacks. Best regards. René I have just forgotten to paste the Koji URL in the above msg... You can look at the F12 result here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2186156 F13 here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2186166 and F14 here : http://koji.fedoraproject.org/koji/taskinfo?taskID=2186173 Best regards. René. APPROVED. Parag, thank you very much. Best regards. René New Package CVS Request ======================= Package Name: kanjistrokeorders-fonts Short Description: Font to view stroke order diagrams for Kanji, Kana and etc... Owners: uggla Branches: F-12 F-13 EL-5 InitialCC: fonts-sig CVS Done kanjistrokeorders-fonts-2.014-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kanjistrokeorders-fonts-2.014-4.fc13 kanjistrokeorders-fonts-2.014-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kanjistrokeorders-fonts-2.014-4.fc12 kanjistrokeorders-fonts-2.014-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. kanjistrokeorders-fonts-2.014-4.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: kanjistrokeorders-fonts New Branches: F14 EL6 Owners: uggla Git done (by process-git-requests). There is already a f14 branch, so only did the EL-6 one. |