Bug 579548

Created attachment 404553 [details]
File: backtrace

Hi,

the PDF is broken and the viewer crashes inside of openjpeg-libs during decoding of an embedded jpeg.
I think that function opj_image_create0() doesn't allocate image correctly and when opj_image_destroy() is called then it crashes (in j2k_decode()).
Btw, it is also reproducible with pdftops.

Thank you for the PDF Alan

Marek

P.S.: I'm reassigning this to openjpeg

*** Bug 574832 has been marked as a duplicate of this bug. ***

*** Bug 560504 has been marked as a duplicate of this bug. ***

(In reply to comment #2)
> I think that function opj_image_create0() doesn't allocate image correctly and
> when opj_image_destroy() is called then it crashes (in j2k_decode()).

PDF file referenced in comment #0 is no longer available for download, but I tracked crash on some other PDF to the same problem.  opj_image_create0() is expected to calloc() memory, rather than malloc() (without memsetting to 0), which may later lead to attempt to use or free uninitialized pointer, leading to crash.

It seems this problem was introduced upstream shortly before 1.3 release:
  http://code.google.com/p/openjpeg/source/detail?r=467

This commit changes opj_malloc to not memset 0 all allocated memory, and opj_calloc is rather used where needed.  However, opj_image_create0() was not fixed, which was corrected shortly after 1.3, but there does not seem to be any release containing this fix:
  http://code.google.com/p/openjpeg/source/detail?r=501

Ping.

*** Bug 639177 has been marked as a duplicate of this bug. ***

The PDF I uploaded in 574832 still crashes evince for me.

Can you test if these packages fixes the crash for you?

http://koji.fedoraproject.org/koji/taskinfo?taskID=2505823

That openjpeg update made it work for me.

Created attachment 451025 [details]
git diff patch

As the scratch build above will be garbage collected after some time, attaching patch witch changes it has on top of current Rawhide version.  Adds patch for bug #609385 too.

We really need to restart the non-responsive maintainer process on this package --- see bug #492218.

This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

This bug should have been closed out as soon as openjpeg-1.3-9.1 or greater was pushed to Fedora 13.

(In reply to comment #14)
> This bug should have been closed out as soon as openjpeg-1.3-9.1 or greater was
> pushed to Fedora 13.

This is what Fedora currently has:

Fedora-12: http://koji.fedoraproject.org/packages/openjpeg/1.3/6.fc12
Fedora-13: http://koji.fedoraproject.org/packages/openjpeg/1.3/7.fc13
Fedora-14: http://koji.fedoraproject.org/packages/openjpeg/1.3/9.fc14
Fedora-Rawhide: http://koji.fedoraproject.org/packages/openjpeg/1.3/9.fc14

openjpeg-1.3-9.1 seems to refer to my testing patch NVR in comment #11.

Anyway to get 1.3-9.1 pushed to F13 and F14? Since I seem to be running a new version then what is in F14 as well?

The reason no push has occurred is that the package maintainer is AWOL.  I'd be happy to take ownership of this package in Fedora (it'd make sense since I maintain it in RHEL), but the non-responsive-maintainer process seems to be stalled.  See comments above.

Is Callium still the maintainer? or is it someone else now?

Callum is still the nominal maintainer.  He hasn't responded to my request for commit privs, nor indeed to anything else in about a year.  See bug #492218.

openjpeg-1.3-10.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/openjpeg-1.3-10.fc14

openjpeg-1.3-10.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/openjpeg-1.3-10.fc13

openjpeg-1.3-10.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/openjpeg-1.3-10.fc12

openjpeg-1.3-10.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update openjpeg'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/openjpeg-1.3-10.fc14

openjpeg-1.3-10.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

openjpeg-1.3-10.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.