Bug 579593
Summary: | Review Request: python3-cherrypy - Pythonic, object-oriented web development framework | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dave Malcolm <dmalcolm> |
Component: | Package Review | Assignee: | Tim Lauridsen <tim.lauridsen> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, tim.lauridsen |
Target Milestone: | --- | Flags: | tim.lauridsen:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | python3-cherrypy-3.2.0-0.rc1.r2567.1.fc13 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-04-22 16:03:15 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 530636 |
Description
Dave Malcolm
2010-04-05 23:49:41 UTC
rpmlint output: python3-cherrypy.src: W: spelling-error Summary(en_US) Pythonic -> Python, Polyphonic, Phonically python3-cherrypy.src: W: invalid-url Source0: CherryPy-r2567.tar.gz python3-cherrypy.noarch: W: spelling-error Summary(en_US) Pythonic -> Python, Polyphonic, Phonically 2 packages and 0 specfiles checked; 0 errors, 3 warnings. "Pythonic" is a commonly-used word within the Python community, and see the specfile for the reasons for the nonstandard source URL. Scratch building in Koji here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2096462 I will take this one :) MUST: * package is named according to the Package Naming Guidelines . * spec file name match base package * package meet Packaging Guidelines . * package is licensed with a Fedora approved license and meet the Licensing Guidelines . * License field match the actual license. * available license(s) file(s) is included in %doc. * spec file is written in American English. * spec file is legible. * sources match upstream (md5sum) not possible because source is pulled from upstream SVN (See Notes in Spec) ? package compile on x86 * build dependencies is listed in BuildRequires * no locales * no shared libs * package not relocatable * package own all directories that it creates. * no duplicate files in the %files listing. * Permissions on files must be set properly. (%defattr(...) line) * %clean section present and contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT) * package is consistently using macros * package contain code, or permissable content * no large doc * %doc does not affect runtime * no headers * no static libs * no *.pc files * no *.so.* libs * no -devel packages * package dont contain .la libtool archives. * not a GUI app. * no files or directories already owned by other packages. * %install begins with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) * filenames is valid UTF-8 SHOULD: ? I have not tested if it builds * no scriptlets * no subpackages I don't have the setup to test if it builds and you scratch build looks failed ? So if you can supply an not failing build, i will approve it Thanks. It turned out that several of the tests within test_states.py can hang, and did when run within Koji, leading to builds eventually timing out. I've added a patch to remove these tests. Updated specfile: http://dmalcolm.fedorapeople.org/python3-packaging/python3-cherrypy/python3-cherrypy.spec Updated SRPM: http://dmalcolm.fedorapeople.org/python3-packaging/python3-cherrypy/python3-cherrypy-3.2.0-0.rc1.r2567.1.fc14.src.rpm Successful build within Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2126843 Looks fine. APPROVED New Package CVS Request ======================= Package Name: python3-cherrypy Short Description: Pythonic, object-oriented web development framework Owners: dmalcolm Branches: F-13 InitialCC: CVS done (by process-cvs-requests.py). python3-cherrypy-3.2.0-0.rc1.r2567.1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python3-cherrypy-3.2.0-0.rc1.r2567.1.fc13 Thanks. Imported and built into F-13 and devel. python3-cherrypy-3.2.0-0.rc1.r2567.1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |