Bug 579610

Summary: wrong usage of strcpy in parsing command line
Product: [Fedora] Fedora Reporter: Daiki Ueno <dueno>
Component: eblookAssignee: Daiki Ueno <dueno>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: i18n-bugs, petersen
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: eblook-1.6.1-8.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-05-11 19:42:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch to fix wrong usage of strcpy none

Description Daiki Ueno 2010-04-06 03:31:19 UTC
Created attachment 404590 [details]
patch to fix wrong usage of strcpy

eblook.c:parse_command_line() uses strcpy on overlapped memory areas.  This may corrupt the original command line arguments.  Actually, the following eblook command is not parsed correctly on my environment F-13 (x86-64) with eblook version 1.6.1-6.

 $ eblook
 Warning: you should specify a book directory first
 
 eblook> set prompt "eblook> "
 eblook  show prompt
 eblook  
 eblook  

Of course, the line after "eblook> set prompt..." should start with "eblook> " not "eblook  ".

I'll notify the upstream, but the patch is attached.

Comment 1 Jens Petersen 2010-04-15 10:57:06 UTC
Thanks for the report and patch.

Perhaps you would like to take over the package? :)
Unfortunately I don't really have enough time for eb these days. :-|

Comment 2 Daiki Ueno 2010-04-16 00:30:31 UTC
Sure.  Could you tell me how to proceed, just adding myself to pkgdb is ok?

Comment 3 Fedora Admin XMLRPC Client 2010-04-16 06:01:33 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 4 Jens Petersen 2010-04-16 06:03:07 UTC
Thanks :)

Comment 5 Fedora Update System 2010-04-16 07:48:20 UTC
eblook-1.6.1-8.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/eblook-1.6.1-8.fc13

Comment 6 Fedora Update System 2010-04-16 07:49:49 UTC
eblook-1.6.1-8.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/eblook-1.6.1-8.fc12

Comment 7 Fedora Update System 2010-04-16 07:50:57 UTC
eblook-1.6.1-8.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/eblook-1.6.1-8.fc11

Comment 8 Fedora Update System 2010-04-16 23:37:03 UTC
eblook-1.6.1-8.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update eblook'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/eblook-1.6.1-8.fc11

Comment 9 Fedora Update System 2010-04-16 23:39:18 UTC
eblook-1.6.1-8.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update eblook'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/eblook-1.6.1-8.fc13

Comment 10 Fedora Update System 2010-04-16 23:40:20 UTC
eblook-1.6.1-8.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update eblook'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/eblook-1.6.1-8.fc12

Comment 11 Fedora Update System 2010-05-11 19:42:46 UTC
eblook-1.6.1-8.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2010-05-11 19:47:54 UTC
eblook-1.6.1-8.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2010-05-12 12:17:35 UTC
eblook-1.6.1-8.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.