Bug 580650

Summary: virt-inspector warns "No grub default specified at /usr/lib/perl5/Sys/Guestfs/Lib.pm at [...]"
Product: [Fedora] Fedora Reporter: Eric Blake <eblake>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 13CC: mbooth, rjones, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: libguestfs-1.2.2-1.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-04-08 14:34:53 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Eric Blake 2010-04-08 13:30:20 EDT
Description of problem:
virt-inspector spat out several suspicious messages, before exiting with non-zero status, when inspecting an existing rawhide guest image

Version-Release number of selected component (if applicable):
$ virt-inspector --verseion

How reproducible:

Steps to Reproduce:
1. Using the LiveCD for F13 virtualization test day, with a mount to see my existing guest images on the host machine
2. virt-inspector /sysroot/libvirt/images/rawhide.img
Actual results:
Most of the command is okay, but the first line is suspicious, and the final line demonstrated the problem:

$ virt-inspector /sysroot/libvirt/images/rawhide.img
No grub default specified at /usr/lib/perl5/Sys/Guestfs/Lib.pm line 1646.
linux fedora i386 14 on /dev/vg_vmrawhide/lv_root:
    /dev/vg_vmrawhide/lv_root      /
    /dev/sda1                      /boot
    /dev/vg_vmrawhide/lv_swap      swap
    mesa-libGL 7.8
    gok 2.30.0
Can't use an undefined value as an ARRAY reference at /usr/bin/virt-inspector line 411.
$ echo $?

Expected results:
reasonable information, and exit status of 0

Additional info:
reproduced on other images as well (F13, Windows 2k8):
$ virt-inspector /sysroot/libvirt/images/windows_2008.img 
windows  on /dev/sda1:
    /dev/sda1                      /
      type: ntfs
      content: windows-root
Can't use an undefined value as an ARRAY reference at /usr/bin/virt-inspector line 411.
Comment 1 Richard W.M. Jones 2010-04-08 13:49:08 EDT
I believe that this change:
fixes the "undefined value as an ARRAY reference" error.
It just missed version 1.0.85.

The warning about "no grub default" is still in the code,
and should be made less scary.
Comment 2 Richard W.M. Jones 2010-04-08 14:34:53 EDT
I removed this warning upstream as it is fairly
useless for the end user:
Comment 3 Fedora Update System 2010-04-09 10:09:53 EDT
libguestfs-1.2.1-1.fc13 has been submitted as an update for Fedora 13.
Comment 4 Fedora Update System 2010-04-13 03:43:26 EDT
libguestfs-1.2.2-1.fc13 has been submitted as an update for Fedora 13.
Comment 5 Fedora Update System 2010-04-30 19:46:37 EDT
libguestfs-1.2.2-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.