Bug 580873
| Summary: | Review Request: libdb - Oracle Berkeley DB version 5 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jindrich Novy <jnovy> |
| Component: | Package Review | Assignee: | Jaroslav Škarvada <jskarvad> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jskarvad, notting, paul, pknirsch |
| Target Milestone: | --- | Flags: | jskarvad:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-04-21 06:12:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jindrich Novy
2010-04-09 10:20:51 UTC
[NO] rpmlint is silent. libdb-cxx.x86_64: W: no-documentation > Probably OK. libdb-cxx.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_cxx-5.0.so 0775 > 0755? libdb-devel-static.x86_64: W: spelling-error %description -l en_US statical -> statically, statistical, static > First and third variants sounds better. libdb-devel-static.x86_64: W: no-documentation > Probably OK. libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/examples_c/bench_001.c libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/LoadIndexKeywords.aspx libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/SearchHelp.aspx libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/styles/Whidbey/presentation.css libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/scripts/Dropdown.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/scripts/EventUtilities.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/scripts/highlight.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/scripts/script_feedBack.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/scripts/script_manifold.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/scripts/CommonUtilities.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/styles/Presentation.css libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/TOC.css libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/Index.aspx libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/scripts/CheckboxMenu.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/Web.Config libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/TOC.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/WebTOC.xml libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/WebKI.xml libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/scripts/SplitScreen.js libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/FillNode.aspx libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/csharp/styles/highlight.css > Mostly cosmetic, worth to fix? libdb-java.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_java-5.0.so 0775 > 0755? libdb-sql.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dbsql ['/usr/lib64'] > rpath should be killed. libdb-sql.x86_64: W: no-documentation > Probably OK. libdb-sql.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_sql-5.0.so 0775 > 0755? libdb-sql.x86_64: W: devel-file-in-non-devel-package /usr/include/libdb/dbsql.h > libdb-sql-devel for one file or OK as is? libdb-tcl.x86_64: W: no-documentation > Probably OK. libdb-tcl.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_tcl-5.0.so 0775 > 0755? libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_printlog ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_dump ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_archive ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_deadlock ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_log_verify ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_upgrade ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_load ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_recover ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_verify ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_stat ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_checkpoint ['/usr/lib64'] libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_hotbackup ['/usr/lib64'] > rpath should be killed. libdb-utils.x86_64: W: no-documentation > Probably OK. libdb.x86_64: E: non-standard-executable-perm /lib64/libdb-5.0.so 0775 > 0755? 10 packages and 0 specfiles checked; 18 errors, 28 warnings. [YES] Package meets naming guidelines. > Please use integer release if pushed to CVS. [YES] Package meets packaging guidelines. > Looks OK. [YES] Spec file matches base package name. [YES] License file is present, matching with spec file. [YES] Licensing Guidelines are met. [YES] Spec file is legible and in American English. [YES] Sources match upstream. [YES] Package builds OK. [YES] BuildRequires is correct. > There is no need to list util-linux-ng, see exception. > It builds in mock, thus at least nothing missing here. [?] ldconfig is called in %post/%postun for every package with DSO > It seems the ldconfig is not called for cxx subpackage. [YES] Package doesn't bundle copies of system libraries. [YES] Package owns all the directories it creates. > Looks OK. [YES] Package has no duplicity in %files. > Looks OK. [NO] Permission on files are set properly. > deffatr should be (-,root,root,-). > Some libraries are installed with mode 0775, see rpmlint output above. [N/A] Package has correctly installed .desktop file. [YES] %clean section is correct. [YES] Spec file has consistant macro usage. [YES] Package is code or permissable content. [YES] %doc files don't affect runtime. > Looks OK. [NO] Header files must be in a -devel package. > libdb-sql-devel for /usr/include/libdb/dbsql.h or OK as is? Same as the rpmlint output above. [YES] Static libraries must be in a -static package. [YES] If a package contains library files with a suffix, then library files that end in .so must go in a -devel package. [NO] Devel packages must require the base package using a fully versioned dependency. > There is no dependency in devel-static subpackage. > Missing dependency for cxx subpackage, is that OK? [YES] No .la libtool archives. [YES] Package doesn't own files/directories that other packages own. [YES] Package has rm -rf $RPM_BUILD_ROOT at beginning of %install. [YES] All files including spec are valid UTF-8 Should items: [YES] Package builds in mock. Thanks, new scratch build (including SRPM) is located here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2117077 > libdb-cxx.x86_64: E: non-standard-executable-perm /usr/lib64/libdb_cxx-5.0.so > 0775 > > 0755? I saw no 0775 permissions in the output rpms but added fix to enforce 0755 permissions for every library. > libdb-devel-static.x86_64: W: spelling-error %description -l en_US statical -> > statically, statistical, static > > First and third variants sounds better. Fixed. > libdb-devel.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/libdb-devel-5.0.21/csharp/LoadIndexKeywords.aspx > > Mostly cosmetic, worth to fix? The C# documentation should go away and it is gone now :) > libdb-sql.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/dbsql > ['/usr/lib64'] > > rpath should be killed. Added --disable-rpath to configure and using chrpath -d to be sure. > libdb-sql.x86_64: W: devel-file-in-non-devel-package /usr/include/libdb/dbsql.h > > libdb-sql-devel for one file or OK as is? Yep, I would leave it as is. The tiny header file is not worth a separate subpackage. > libdb-utils.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/db_printlog > ['/usr/lib64'] > > rpath should be killed. It is now killed. > [YES] Package meets naming guidelines. > > Please use integer release if pushed to CVS. the 0.x release is used for review only. The first version will be 1 and on. > [YES] BuildRequires is correct. > > There is no need to list util-linux-ng, see exception. Removed. > [?] ldconfig is called in %post/%postun for every package with DSO > > It seems the ldconfig is not called for cxx subpackage. Added. > [NO] Permission on files are set properly. > > deffatr should be (-,root,root,-). > > Some libraries are installed with mode 0775, see rpmlint output above. Fixed. > [NO] Devel packages must require the base package using a fully versioned > dependency. > > There is no dependency in devel-static subpackage. > > Missing dependency for cxx subpackage, is that OK? Added. Great, the only "relevant" remaining warning: libdb-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/libdb-devel-5.0.21/examples_c/bench_001.c But it is only cosmetic. Fixed. New packages are here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2118391 New Package CVS Request ======================= Package Name: libdb Short Description: The Berkeley DB database library for C Owners: jnovy Branches: F-14 InitialCC: We aren't doing F-14 branches currently, did you just want devel? Or did you want F-13 ? Kevin, sorry for confusion, devel branch is what I had in mind. Thanks. New Package CVS Request ======================= Package Name: libdb Short Description: The Berkeley DB database library for C Owners: jnovy Branches: devel InitialCC: *** Bug 580220 has been marked as a duplicate of this bug. *** CVS done (by process-cvs-requests.py). Now that libdb is established in Rawhide, and compat-db includes a db4 implementation, is it now time to retire db4? Doing it this early in the F14 cycle will allow time for the FTBFS bugs that will inevitably arise from this to be resolved. |