Bug 581216

*** Bug 561169 has been marked as a duplicate of this bug. ***

This program is the default TeX editor in TeX Live 2009 Windows Version. It's small and useful. Its build process is quite straight-forward. It's maintained by the same author of XeTeX.

May somebody help reviewing this package?

Hello LI:

I started to package this program some time ago but for some reasons I stopped. Just a few though unofficial comments.

** If you run rpmlint on binary rpm file you will see:

texworks.x86_64: W: file-not-utf8 /usr/share/doc/texworks-0.2.3/README
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile's %prep section for example using iconv(1).

See here for more informations:

https://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8

** Do you prefer to install the files manually instead of patching the TeXworks.pro file? I ask this because the instructions in README says to modify the file TeXworks.pro

Cheers,
Germán.

A new build

Spec URL: https://dl.dropbox.com/u/612778/texworks.spec
SRPM URL: https://dl.dropbox.com/u/612778/texworks-0.2.3-2.fc13.src.rpm
Koji Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2133416

Changes:
- Fix some strange characters in README
- Patch TeXworks.pro to use qmake mechanism to install files and fix DSO linking
  problem

(In reply to comment #3)
> ** Do you prefer to install the files manually instead of patching the
> TeXworks.pro file? I ask this because the instructions in README says to modify
> the file TeXworks.pro
I just would not like to make any patch which is not upstreamable.
I will try to commit these two patch upstream.

I don't see major problems in this package. However, I have found that the texworks is under 'Accessories' in the menu while other tex related editors like kile are under Office. The desktop file can place the Office as a category.

A new revision

Spec URL: https://dl.dropbox.com/u/612778/texworks.spec
SRPM URL: https://dl.dropbox.com/u/612778/texworks-0.2.3-3.fc13.src.rpm

Change:
- Move to menu category 'Office'

(In reply to comment #5)
> I don't see major problems in this package. However, I have found that the
> texworks is under 'Accessories' in the menu while other tex related editors
> like kile are under Office. The desktop file can place the Office as a
> category.

New Package CVS Request
=======================
Package Name: texworks
Short Description: A simple IDE for authoring TeX documents
Owners: cheeselee
Branches: F-11 F-12 F-13
InitialCC:

mrlhwliberty: I am unable to find your address in the "packagers" group. You must be in this group to approve package reviews. What is your Fedora account system name?

Also, if you are new to reviewing packages, I strongly advise you to use a checklist showing that you checked all the various guidelines and confirm that the package meets them.

CVS done (by process-cvs-requests.py).

texworks-0.2.3-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/texworks-0.2.3-3.fc13

texworks-0.2.3-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

What is going on here? I don't see a proper review here.

mrlhwliberty, please fill out the required fields in the account system, it's hard to find you.

mrlhwliberty has FAS account "helloworld1"

I have checked the FAS, the email is correct and the bugzilla as well. What is the problem?

IMHO all packagers should use real name and this information should be available in the account systen.

But the main problem is that you did not document what checks you ran during the review.

Ok, I will change the name in bugzilla to be the same as FAS.
Sorry for the problem, I am new to do formal reviews. I have followed the review guideline to check the package but I didn't document it explicitly. I will list it explicitly next time.