Bug 581278
| Summary: | Review Request: erlang-etap - Erlang testing library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | dcantrell:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | erlang-etap-0.3.4-2.el4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-07 22:11:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 581281 | ||
|
Description
Peter Lemenkov
2010-04-11 14:02:29 UTC
Koji scratchbuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=2182759 rpmlint: Sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/erlang-etap-0.3.4-1.fc12.ppc.rpm erlang-etap.ppc: E: no-binary erlang-etap.ppc: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Sulaco ~/rpmbuild/SPECS: Both messages *must* be ignored - in fact, application contains only noarch-data, but installed into arch-specific %{_libdir}. Unlike python stuff being divided into noarch and arch-dependent, every erlang package should be installed into %{libdir}/erlang which makes every erlang package arch-dependent. New build: http://peter.fedorapeople.org/erlang-etap.spec http://peter.fedorapeople.org/erlang-etap-0.3.4-2.fc12.src.rpm Narrowed explicit requires. dcantrel@mitre ~$ rpmlint erlang-etap-0.3.4-2.fc12.src.rpm erlang-etap.src: W: invalid-url Source0: ngerakines-etap-17b8d43.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. 1) "erlang-etap.src: W: invalid-url Source0: ngerakines-etap-17b8d43.tar.gz"
This warning is ok given that the source is downloaded via git. The spec file contains instructions for downloading the source.
If there is a git tag for the release you are building, I would recommend specifying that download URL in the spec file comment. e.g.:
http://github.com/ngerakines/etap/tarball/etap-0.3.2
But I do not see a tag for 0.3.4.
Disregard comment #4, I see it now. $ koji build --scratch dist-f14 erlang-etap-0.3.4-2.fc12.src.rpm Uploading srpm: erlang-etap-0.3.4-2.fc12.src.rpm [====================================] 100% 00:00:03 21.00 KiB 5.43 KiB/sec Created task: 2197207 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2197207 None Watching tasks (this may be safely interrupted)... 2197207 build (dist-f14, erlang-etap-0.3.4-2.fc12.src.rpm): free 2197207 build (dist-f14, erlang-etap-0.3.4-2.fc12.src.rpm): free -> open (ppc04.phx2.fedoraproject.org) 2197208 buildArch (erlang-etap-0.3.4-2.fc12.src.rpm, x86_64): free 2197209 buildArch (erlang-etap-0.3.4-2.fc12.src.rpm, i686): free 2197208 buildArch (erlang-etap-0.3.4-2.fc12.src.rpm, x86_64): free -> open (xb-01.phx2.fedoraproject.org) 2197209 buildArch (erlang-etap-0.3.4-2.fc12.src.rpm, i686): free -> open (x86-04.phx2.fedoraproject.org) 2197209 buildArch (erlang-etap-0.3.4-2.fc12.src.rpm, i686): open (x86-04.phx2.fedoraproject.org) -> closed 0 free 2 open 1 done 0 failed 2197208 buildArch (erlang-etap-0.3.4-2.fc12.src.rpm, x86_64): open (xb-01.phx2.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 2197207 build (dist-f14, erlang-etap-0.3.4-2.fc12.src.rpm): open (ppc04.phx2.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 2197207 build (dist-f14, erlang-etap-0.3.4-2.fc12.src.rpm) completed successfully Packaging work looks good and it builds on all arches. I do not really know how to test this package to see that it works, so I will assume you have done that. Approved. New Package CVS Request ====================== Package Name: erlang-etap Short Description: Erlang testing library Owners: peter Branches: F-11 F-12 F-13 EL-6 EL-5 EL-4 InitialCC: CVS Done except F-11 new branches are now closed for it erlang-etap-0.3.4-2.el5,couchdb-0.10.2-8.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.el5,couchdb-0.10.2-8.el5 erlang-etap-0.3.4-2.fc12,couchdb-0.10.2-8.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.fc12,couchdb-0.10.2-8.fc12 erlang-etap-0.3.4-2.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.el4 couchdb-0.10.2-8.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/couchdb-0.10.2-8.fc11 erlang-etap-0.3.4-2.fc13,couchdb-0.10.2-8.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.fc13,couchdb-0.10.2-8.fc13 erlang-etap-0.3.4-2.fc13, couchdb-0.10.2-8.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-etap couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.fc13,couchdb-0.10.2-8.fc13 couchdb-0.10.2-8.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/couchdb-0.10.2-8.fc11 erlang-etap-0.3.4-2.fc12, couchdb-0.10.2-8.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-etap couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.fc12,couchdb-0.10.2-8.fc12 erlang-etap-0.3.4-2.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-etap'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.el4 erlang-etap-0.3.4-2.el5, couchdb-0.10.2-8.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-etap couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.el5,couchdb-0.10.2-8.el5 erlang-etap-0.3.4-2.fc12, couchdb-0.10.2-8.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. couchdb-0.10.2-8.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. erlang-etap-0.3.4-2.fc13, couchdb-0.10.2-8.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. erlang-etap-0.3.4-2.el5, couchdb-0.10.2-8.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. erlang-etap-0.3.4-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. |