Bug 583658
| Summary: | livecd-iso-to-disk --format fails with existing LV on USB | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alan Pevec <apevec> | ||||||||
| Component: | livecd-tools | Assignee: | Alan Pevec <apevec> | ||||||||
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | low | Docs Contact: | |||||||||
| Priority: | low | ||||||||||
| Version: | 13 | CC: | apevec, cpelland, dhuff, Jasper.Hartline, katzj, ovirt-maint, vbian, wtogami | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2010-08-13 18:52:58 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 582626 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alan Pevec
2010-04-19 10:48:03 UTC
Created attachment 408189 [details]
livecd-iso-to-disk --format fails with existing LV on USB
Created attachment 410206 [details]
change to Dave's patch
I found 2 code issues:
1. The new function checkLVMActive() will fail silently if the lvm2 package is
not installed.
2. The path expansion in the call to pvs,
pvs -o vg_name --noheadings $dev $dev${dev_delim}[0-9]*
will miss SD/MMC device partitions, which are labeled p1, p2, ... instead of
1, 2, ...
So, I propose,
1. that we not redirect standard error to /dev/null
2. use a more general path expansion.
-+ for vg in $(pvs -o vg_name --noheadings $dev $dev${dev_delim}[0-9]* 2>/dev/null|sort -u); do
++ for vg in $(pvs -o vg_name --noheadings $dev${dev_delim}* |sort -u); do
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component. Created attachment 412394 [details]
simplified patch
Closing, this is in git. Thanks guys. |