Bug 584220
| Summary: | Review Request: python-gevent - A coroutine-based Python networking library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Silas Sewell <silas> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mgoldman, notting, orion, silas, skottler, tomspur |
| Target Milestone: | --- | Flags: | tomspur:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-gevent-0.12.2-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-05-26 00:56:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Silas Sewell
2010-04-21 01:32:30 UTC
Review:
Good:
- name ok
- %build ok
- %{optflags} there
- %clean there
- %install ok
- %files ok
- noarch not possible
- builds in koji (without BR setuptools):
http://koji.fedoraproject.org/koji/taskinfo?taskID=2130784
- no .la
- no libs
- no devel files
- license ok (MIT)
- sources match upstream: 97c75039a67593d3f5375fb77f73bbe7
- rpmlint same as posted above, it would be nice to avoid some spelling-errors, but they don't look 'wrong' to me. -> Ignorable
Needswork:
- BR: python-setuptools is not needed (the egg is builded by distutils)
- The %{__rm} is a matter of taste - looks not that good...
###############################################################################
Just one should: remove BR: python-setuptools
###############################################################################
APPROVED
The needswork above should be addressed. Change: http://github.com/silas/rpms/commit/ac5ae97062af77ed7f159183332fad395ccfabe3 SRPM: http://github.com/downloads/silas/rpms/python-gevent-0.12.2-2.fc14.src.rpm rpmlint [silas@fox rpmbuild]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm python-gevent.src: W: spelling-error Summary(en_US) coroutine -> co routine, co-routine, subroutine python-gevent.src: W: spelling-error %description -l en_US coroutine -> co routine, co-routine, subroutine python-gevent.src: W: spelling-error %description -l en_US greenlet -> green let, green-let, Greenland python-gevent.src: W: spelling-error %description -l en_US libevent -> lib event, lib-event, libertine python-gevent.src: W: spelling-error %description -l en_US greenlets -> green lets, green-lets, Greenland python-gevent.src: W: spelling-error %description -l en_US http -> HTTP python-gevent.src: W: spelling-error %description -l en_US dns -> dens, dins, dons ... (repeats above) 3 packages and 0 specfiles checked; 0 errors, 14 warnings. New Package CVS Request ======================= Package Name: python-gevent Short Description: Coroutine-based Python networking library Owners: silas Branches: F-12 F-13 CVS done (by process-cvs-requests.py). python-gevent-0.12.2-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-gevent-0.12.2-2.fc13 python-gevent-0.12.2-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-gevent-0.12.2-2.fc12 python-gevent-0.12.2-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. python-gevent-0.12.2-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. I would like to see this in EPEL6. Would you be willing to maintain this there, or shall I? Package Change Request ====================== Package Name: python-gevent New Branches: el5 el6 Owners: goldmann As a result of bug 1032912 I've decided to go ahead and ask for creation of EPEL branches. This package is required for docker-io. Orion, if you want to co-maintain this package - feel free. I'm willing to comaintain the package as well. Git done (by process-git-requests). |