Bug 58442
| Summary: | RFE: split allocate hd_struct per major in sd | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Pete Zaitcev <zaitcev> | ||||||||||||
| Component: | kernel | Assignee: | Pete Zaitcev <zaitcev> | ||||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Brian Brock <bbrock> | ||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||
| Priority: | medium | ||||||||||||||
| Version: | 7.2 | CC: | conway_heather, dledford, gary_lerhaupt, gaudet_roger, goggin_edward, john_hull, lwoodman, matt_domsch, mcafee_thomas, seto_jimmy, tsombakos_mark | ||||||||||||
| Target Milestone: | --- | Keywords: | FutureFeature | ||||||||||||
| Target Release: | --- | ||||||||||||||
| Hardware: | i386 | ||||||||||||||
| OS: | Linux | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Fixed In Version: | Doc Type: | Enhancement | |||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||
| Clone Of: | Environment: | ||||||||||||||
| Last Closed: | 2002-11-05 21:28:05 UTC | Type: | --- | ||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||
| Documentation: | --- | CRM: | |||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
| Embargoed: | |||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Pete Zaitcev
2002-01-16 18:27:01 UTC
Created attachment 42615 [details]
Done, but is marred by a tricky oops in ext2 - DON'T USE
any reason why vmalloc is a bad idea ? The patch must be used with SCSI fixes in RH >= 2.4.9-18.2 or Marcelo >= 2.4.18-pre2. [Arjan - thanks for the note, yes vmalloc is a good idea. We do not do DMA into that area :)] *** Bug 61364 has been marked as a duplicate of this bug. *** Created attachment 51687 [details]
Same fix for 2.4.18-0.13
Created attachment 51706 [details]
Same fix for Pensacola.
I would appreciate if Heather tried out the candidate fix. Accepted by Marcelo into 2.4.19-pre7. Test while it's hot :) The patch to v2.4.18 applied cleanly and the kernel recompiled without any problems. I have been working with the Qlogic v4.47.11 driver and have not run into the problems of phantom LUNs being reported. The patch to v2.4.9 applied cleanly, but the kernel will not recompile properly. I'm using Pensacola 4/10 release (v2.4.9-26beta.59). When compiling sd.o as either static or a module, I get the following: sd.c: In function 'sd_ioctl': sd.c:241: 'sd' undeclared (first use in this function) sd.c:241: (Each undeclared identifier is reported only once sd.c:241: for each function it appears in.) make[3]: *** [sd.o] Error 1 make[3]: Leaving directory '/usr/src/linux-2.4.9/drivers/scsi' make[3]: *** [first_rule] Error 2 make[3]: Leaving directory '/usr/src/linux-2.4.9/drivers/scsi' make[3]: *** [subdir_scsi] Error 2 make[1]: Leaving directory '/usr/src/linux-2.4.9/drivers' make: *** [_dir_drivers] Error 2 Created attachment 58786 [details]
Better fix for Pensacola
The Advanced Server has its own team in Boston now, headed by Larry Woodman. Fixing AS has to be discussed with him, I am not commiting such invasive chances to his codebase without permission. So, I think we can close it as Rawhide. Phantom LUNs are something else, they have to be tracked with their own entry. Using attachment #51706 [details], the patch applies cleanly, but the kernel fails compilation when compiling the sd.o with the error message posted on 5/21/2002. Would it be possible to repost attachment #58786 [details]? (The current one is not a patch.) Has there been any other work done on this issue? Thanks. Created attachment 66004 [details]
Better fix for Pensacola (right file this time)
I am terribly sorry, got right file this time. Did you talk to Larry yet? Do you want me to poke him? As far as I can tell, the change should be acceptable for AS2.1, it does not change ABI (or so I think...). Has this been closed in a Pensacola errata? -Gary Is this patch going to be included in an upcoming 2.1 AS errata? I think Pensacola is going to take it; Its bug 61364 was de-aliased for tracking. Pete, since this was taken in 8.0, and the fix for Pensacola has its own tracking number, can you close this issue? Closing in RH8.0. |