Bug 584994
| Summary: | when assigning ldap groups to role ui pagination wrong | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Simeon Pinder <spinder> | ||||||
| Component: | Core UI | Assignee: | Simeon Pinder <spinder> | ||||||
| Status: | CLOSED WONTFIX | QA Contact: | Corey Welton <cwelton> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | unspecified | CC: | skondkar | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2010-09-21 01:49:30 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 577267 | ||||||||
| Attachments: |
|
||||||||
|
Description
Simeon Pinder
2010-04-22 20:40:30 UTC
Simeon You should double check that this feature is still working correctly on other parts of the site, before trying to fix this particular instance Verified that issue is localized to ldap pagination. Fixed in successful master build >= 259. git hash bdbc5d990cd959005e9a7355fc1ba5c1296187d7 Details: Existing pagination controls leverage same db PageControl mechanism used to group and sort requests to db. Solution does not work for LDAP because there are no database calls where pca used, but just queries to ldap server returning PageLists of Maps of Strings. - modified the ldap group query results to be sorted/ordered to respond to same pagination widget controls - cached ldap group list to avoid potentially expensive needless roundtrips to external server. - also added trim() to returned ldap description|name values to elimination pagination sorting issues with different ldap servers handling whitespace different ways. - added ldapGroupForm.jsp so that pagination controls were correctly fed to the UI. Verified on jon build 120 (Revision: 10615) There are two sections on screen to add ldap groups. Pagination on the left section(Groups) is working as expected. If user selects values 15/30/45 from 'Items per page' dropdown, the section displays items accordingly. However on the right section (Assign To Role), If user selects values 15/30/45 from 'Items per page' dropdown, it displays all available items without pagination. Please refer the attached screenshot. Steps to reproduce: 1.Login to jon 2.Navigate to Administration->System Configurations->Settings 3.Enter below details in 'LDAP Configuration Properties' section and click OK button. URL: ldap://win2k3red.test.pnq.com Search Base: dc=test,dc=pnq,dc=com Username: cn=Administrator,cn=Users,dc=test,dc=pnq,dc=com Password: RedHat123 Search Filter: objectclass=* Login Property: cn Group Search Filter: objectclass=group Group Member Filter: member 4.Navigate to Administration->Security->Roles 5.Click on 'ALL Resources Role' link. 6.Click on 'Add To List' button on 'Assigned LDAP Groups' section. 7.Select all the available groups in 'Groups' section (available groups should be more than 15) 8.Click on arrow button. 9.Verify pagination on 'Assign To Role' section. 10.If user selects values 15/30/45 from 'Items per page' dropdown, it displays all available items without pagination. Created attachment 410105 [details]
Screenshot for 'Assign To Role' section pagination
Yep. My bad. Oversight. This is not fixed in successful builds of master >= 284. git commit hash: 4d661b9aec44282fea747d60def24e44d6461caa Verified on latest jon build#136 (10615) When assigning ldap groups to role, observed that pagination is working as expected on 'Groups' and 'Assign To Role' sections on on screen to add ldap groups. However, observed that when user clicks OK button after selecting and assigning the ldap groups, these groups get listed in 'Assigned LDAP Groups' section on the view role screen. If user selects values 15/30/45 from 'Items per page' dropdown, it displays all available items without pagination. Please refer the attached screenshot. Steps to reproduce: 1.Login to jon 2.Navigate to Administration->System Configurations->Settings 3.Enter below details in 'LDAP Configuration Properties' section and click OK button. URL: ldap://win2k3red.test.pnq.com Search Base: dc=test,dc=pnq,dc=com Username: cn=Administrator,cn=Users,dc=test,dc=pnq,dc=com Password: RedHat123 Search Filter: objectclass=* Login Property: cn Group Search Filter: objectclass=group Group Member Filter: member 4.Navigate to Administration->Security->Roles 5.Click on 'ALL Resources Role' link. 6.Click on 'Add To List' button on 'Assigned LDAP Groups' section. 7.Select and assign groups(more than 45) 8.Click on OK button. 9. User is navigated to the view role screen. 10. If user selects values 15/30/45 from 'Items per page' dropdown, it displays all available items without pagination. Created attachment 413722 [details]
Screenshot for view role screen pagination
clsoing per GWT effort |