Bug 58635
Summary: | RFE: kernel RPM script to remove option aacraid lines from modules.conf | ||
---|---|---|---|
Product: | [Retired] Red Hat Linux | Reporter: | Matt Domsch <matt_domsch> |
Component: | kernel | Assignee: | Arjan van de Ven <arjanv> |
Status: | CLOSED WORKSFORME | QA Contact: | Brian Brock <bbrock> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 7.2 | Keywords: | FutureFeature |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | i386 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Enhancement | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2002-01-22 14:26:07 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Matt Domsch
2002-01-21 22:49:27 UTC
It's not quite dropped, but made more generic. In the 2.2 -> 2.4 migration several drivers changed name, so there is a /usr/sbin/module_upgrade script that converts modules.conf driver names.... How to strip such options is a different matter though; the PCI ones shouldn't have actually existed in the first place ;( We didn't have a choice - the hardware teams didn't set their PCI IDs until *after* the 7.2 kernel went gold - and we needed *something* to let us install anyhow. I'm going to write up a patch against Alan's driver that, when options are passed, the table is scanned to see if it's a duplicate, and then warn and not use as an option. Can you hold off on any errata kernel release till I can get this done today? BTW - received a test patch (but probably correct) from Chris Pascoe which solves the 150,000 interrupts/sec problem on ROMBs. I append it below. We're going to test this today too. From: Chris Pascoe [c.pascoe.edu.au] Sent: Tuesday, January 22, 2002 6:58 AM Hi Alan, The problem with millions of interrupts being generated by the aacraid driver on some hardware is caused by reversed arguments to time_before in rx_sync_cmd. This causes every synchronous command sent to the controller to miss acknowledgement, including our one to start the adapter. When interrupts are subsequently re-enabled, we get a continuous stream of interrupts as the command has actually completed, and there is no path in aac_rx_intr to acknowledge the command. The following patch corrects the described problem. --- linux/drivers/scsi/aacraid/rx.c.orig Tue Jan 22 22:40:58 2002 +++ linux/drivers/scsi/aacraid/rx.c Tue Jan 22 22:41:19 2002 @@ -199,7 +199,7 @@ /* * Wait up to 30 seconds */ - while (time_before(start+30*HZ, jiffies)) + while (time_before(jiffies, start+30*HZ)) { udelay(5); /* Delay 5 microseconds to let Mon960 get info. */ /* Regards, Chris The driver in 2.4.9-20 and above doesn't have (and likely won't ever need) the patch which implements MODULE_PARMs for passing in PCI IDs. Since that driver already has all the PCI IDs that Dell cares about, I'm closing this RFE - it won't affect us. |