Bug 587087
| Summary: | Review Request: Spawning - A HTTP server for hosting WSGI python web applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Fenzi <kevin> |
| Component: | Package Review | Assignee: | Terje Røsten <terje.rosten> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, terje.rosten |
| Target Milestone: | --- | Flags: | terje.rosten:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Spawning-0.9.3-0.rc2.5.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-05-21 00:32:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kevin Fenzi
2010-04-28 20:31:55 UTC
I got:
Traceback (most recent call last):
File "/usr/bin/spawning", line 5, in <module>
from pkg_resources import load_entry_point
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 2562, in <module>
working_set.require(__requires__)
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 626, in require
needed = self.resolve(parse_requirements(requirements))
File "/usr/lib/python2.6/site-packages/pkg_resources.py", line 524, in resolve
raise DistributionNotFound(req) # XXX put more info here
pkg_resources.DistributionNotFound: eventlet>=0.9.3
Add req on python-eventlet?
Oops. I of course had that Requires in there before, but removed it when doing some test builds because the eventlet package was not in yet. ;( Anyhow, thanks for catching that and: Spec URL: http://www.scrye.com/~kevin/fedora/Spawning/Spawning.spec SRPM URL: http://www.scrye.com/~kevin/fedora/Spawning/Spawning-0.9.3-0.rc2.2.fc14.src.rpm Thanks, works fine here with a Django app. ! rpmlint
Spawning.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/spawning/spawning_controller.py 0644 /usr/bin/env
Spawning.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/spawning/spawning_child.py 0644 /usr/bin/env
Easy to fix with a sed oneliner.
ok naming of package and spec
ok spec file
might add %global rver 0.9.3rc2 to use in Source0 and %setup?
more explicit in %files might be good:
%{python_sitelib}/*
ok license approved and tag ok. MIT, all files have headers. Good.
ok license in %doc
ok correct language
ok sha1sum on sources and ok url
sha1sum Spawning-0.9.3rc2.tar.gz*
7a5b07fb51692f13e9787f631c09782861073856 Spawning-0.9.3rc2.tar.gz
7a5b07fb51692f13e9787f631c09782861073856 Spawning-0.9.3rc2.tar.gz.spec
might download with wget -N to get correct timestamp on tarball
ok koji build with correct buildreq, see comment #1
ok excludearch
- locale files
- ldconfig
ok no bundling
ok owns, dirs and perms and only once
ok macros
ok code or content
- large docs
ok %doc not affect the runtime
- headers|static in devel|static
- .so in devel
- devel dep on base
- no .la|.a file
- gui with desktop file
ok own just not owned
ok utf-8 file names
ok separate file from upstream
ok trans
ok mock/koji
see comment #1
ok testing
- scriptlets sane
- subpkgs dep on base
- pkgconfig(.pc) in devel
- req on package not on files
ok add man pages
There are some init scripts in rc-scripts, those are not written for
Fedora it seems. However, they still have some value. Include as %doc?
If you have better init scripts available, include those.
Nothing major here, consider the points over when importing.
The package Spawning is APPROVED.
Thanks for the review! FYI: Spec URL: http://www.scrye.com/~kevin/fedora/Spawning/Spawning.spec SRPM URL: http://www.scrye.com/~kevin/fedora/Spawning/Spawning-0.9.3-0.rc2.3.fc14.src.rpm * Fri Apr 30 2010 Kevin Fenzi <kevin> - 0.9.3-0.rc2.3 - Strip out env lines from some files. - Add rc-scripts as doc files. New Package CVS Request ======================= Package Name: Spawning Short Description: A HTTP server for hosting WSGI python web applications Owners: kevin Branches: devel EL-5 InitialCC: CVS done (by process-cvs-requests.py). Spawning-0.9.3-0.rc2.3.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/Spawning-0.9.3-0.rc2.3.el5 Spawning-0.9.3-0.rc2.3.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update Spawning'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/Spawning-0.9.3-0.rc2.3.el5 Hi Kevin, did you see this: Spawning-0.9.3-0.rc2.3.fc14.noarch requires /sbin/runscript Ref: http://thread.gmane.org/gmane.linux.redhat.fedora.devel/132430 Yes I did. :( Sorry about that... adding the example scripts pulled that in and I missed it. ;( I will fix it today. Spawning-0.9.3-0.rc2.4.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/Spawning-0.9.3-0.rc2.4.el5 Spawning-0.9.3-0.rc2.4.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update Spawning'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/Spawning-0.9.3-0.rc2.4.el5 Spawning-0.9.3-0.rc2.4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. Spawning-0.9.3-0.rc2.5.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/Spawning-0.9.3-0.rc2.5.el5 Spawning-0.9.3-0.rc2.5.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |