Bug 588232

Summary:	pic2graph requires coreutils 8.1 or later
Product:	[Fedora] Fedora	Reporter:	Paolo Bonzini <pbonzini>
Component:	groff	Assignee:	Jan Vcelak <jvcelak>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	12	CC:	jvcelak, tsmetana
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	groff-1.18.1.4-21.fc12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-05-20 18:43:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Paolo Bonzini 2010-05-03 07:56:40 UTC

Description of problem:
pic2graph requires mktemp to support

   mktemp prefix-XXXXXX.ext

which was introduced in coreutils 8.1.  So it is broken in Fedora 12.

Version-Release number of selected component (if applicable):
groff-1.18.1.4-20.fc12.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Invoke pic2graph without arguments.
  
Actual results:
mktemp: too few X's in template `/tmp/pic2graph-XXXXXXXX.ps'
mktemp: too few X's in template `/tmp/pic2graph-XXXXXXXX.png'
/usr/bin/pic2graph: line 81: $tmpps: ambiguous redirect

Expected results:
No errors.

Additional info:
Fixed by:

--- /usr/bin/pic2graph.fc12
+++ /usr/bin/pic2graph
@@ -76,4 +76,4 @@
 
-tmpps=`mktemp /tmp/pic2graph-XXXXXXXX.ps`
-tmpfmt=`mktemp /tmp/pic2graph-XXXXXXXX.$format`
+tmpps=`mktemp /tmp/pic2graph-XXXXXX`
+tmpfmt=`mktemp /tmp/pic2graph-XXXXXX`
 trap "rm $tmpps $tmpfmt" 0 2 15

Comment 1 Jan Vcelak 2010-05-04 10:41:24 UTC

Hi Paolo,

thank you for your report. It's fixed. However I didn't use your patch. The tool 'convert' requires the temporary files to have appropriate extensions. Otherwise the result won't be in desired format.

Jan

Comment 2 Fedora Update System 2010-05-04 10:56:21 UTC

groff-1.18.1.4-21.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/groff-1.18.1.4-21.fc12

Comment 3 Paolo Bonzini 2010-05-04 11:51:28 UTC

Thank you!

Comment 4 Fedora Update System 2010-05-04 23:56:52 UTC

groff-1.18.1.4-21.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update groff'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/groff-1.18.1.4-21.fc12

Comment 5 Fedora Update System 2010-05-20 18:43:24 UTC

groff-1.18.1.4-21.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.