Bug 588427

Summary: Review Request: rubygem-Antwrap - A Ruby module that wraps the Apache Ant build tool.
Product: [Fedora] Fedora Reporter: Adam Young <ayoung>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, jesusr, mastahnke, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-12-26 15:30:45 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449, 588406    

Description Adam Young 2010-05-03 13:36:08 EDT
Spec URL: http://github.com/admiyo/MySpecs/blob/master/rubygem-Antwrap.spec
SRPM URL: <srpm info here>
Description: Buildr dependency
Addressable is a replacement for the URI implementation that is part of Ruby's standard library. It more closely conforms to the relevant RFCs and adds support for IRIs and URI templates.
Comment 1 Adam Young 2010-05-03 13:38:46 EDT
Sorry about the typo.  The description should read:

A Ruby module that wraps the Apache Ant build tool. Antwrap can be used to invoke Ant Tasks from a Ruby or a JRuby script.

The SRPM is at 
Comment 2 Adam Young 2010-05-11 09:54:14 EDT

Updated IAW guidance for Ruby Gems:  ABI, define->global, removed duplicate files.
Comment 4 Michael Stahnke 2010-08-29 23:06:43 EDT
rpmlint rubygem-Antwrap-0.7.0-2.fc15.src.rpm 
rubygem-Antwrap.src: E: summary-too-long C A Ruby module that wraps the Apache Ant build tool. Antwrap can be used to invoke Ant Tasks from a Ruby or a JRuby script
rubygem-Antwrap.src:29: W: mixed-use-of-spaces-and-tabs (spaces: line 29, tab: line 29)
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

Can you double-check the license?  The website says LGPL.

Description is very long.  Appears to be malformatted rdoc items. 

No need for the /usr/share/doc creation and file movement. 

ruby_sitelib macro not used. Remove it.

create a %check please.  You will need rjb in the BR(check) for that.
Comment 5 Jason Tibbitts 2010-11-18 08:57:12 EST
There has been no response to the above commentary.
Comment 6 Jesus M. Rodriguez 2010-11-18 10:00:20 EST
I'll be taking this over as it is needed for buildr (our main goal). There has been some patches to this that need to get added. I'll post an updated spec and srpm.