Bug 588472
| Summary: | Review Request:rubygem-rjb - Ruby to java Bridge | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Young <ayoung> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jesusr, mastahnke, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-26 20:30:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 588406 | ||
|
Description
Adam Young
2010-05-03 19:02:32 UTC
Primary thing was to move the gem install into the build step. Other clean up as well: dependencies and define->global. http://github.com/admiyo/MySpecs/blob/cca3bd1a056f9a35636a5e3845a5e034a4e237a0/rubygem-rjb.spec rpmlint is not silent. There is probably more, but we can start with that. rpmlint ../RPMS/x86_64/rubygem-rjb-1.2.0-2.fc13.x86_64.rpm rubygem-rjb.x86_64: W: no-soname /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/lib/rjbcore.so rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/jp_co_infoseek_hp_arton_rjb_RBridge.h rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/rjbexception.c rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/load.c rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/rjb.h rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/rjb.c rubygem-rjb.x86_64: E: wrong-script-interpreter /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/test/test.rb /usr/local/env rubygem-rjb.x86_64: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/test/test.rb 0644L /usr/local/env rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/extconf.h rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/riconv.h rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/riconv.c rubygem-rjb.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/jniwrap.h 1 packages and 0 specfiles checked; 2 errors, 10 warnings. I will be taking this over, I will be bumping rjb up to 1.2.9. I'll post an updated spec and srpm. |