Bug 588654

Thanks for the submission.  My review is below.

* = okay, X = work to be done

* naming fine
X release incorrect.  see:

  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release

X drop the explicit Epoch (it's unnecessary)
X license tag incorrect (it should be ASL 2.0):  see

  http://fedoraproject.org/wiki/Licensing#SoftwareLicenses 

X source appears to have been generated from a different tag.  The difference
  is inconsequential but I'd prefer if it was re-generated.  See the diff here:

  http://overholt.fedorapeople.org/plexus-component-api-1.0-alpha-15.diff

X Requires need to be fixed:  add Requires(post) and Requires(postun) on
  jpackage-utils

* macros okay (but why mix %{__rm} and plain rm?)

X should there be an un-versioned copy of the JAR?

* rpmlint warnings are okay (license covered above and others are ignorable)

$ rpmlint ../SRPMS/plexus-component-api-1.0-alpha15.1.src.rpm 
plexus-component-api.src: W: invalid-license Apache Software License 2.0
plexus-component-api.src: W: invalid-url Source0:
plexus-component-api-1.0-alpha-15.tar.gz
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint ../RPMS/noarch/plexus-component-api-1.0-alpha15.1.fc12.noarch.rpm 
plexus-component-api.noarch: W: invalid-license Apache Software License 2.0
plexus-component-api.noarch: W: no-documentation
plexus-component-api.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-component-api
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint ../RPMS/noarch/plexus-component-api-javadoc-1.0-alpha15.1.fc12.noarch.rpm 
plexus-component-api-javadoc.noarch: W: invalid-license Apache Software License 2.0
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Fixed all issues except "source appears to have been generated from a different tag" which I think don't need to fix,it was just caused by the auto-generated svn placeholder $Data$ for different timezone.

Please review again.

Spec URL: http://yyang.fedorapeople.org/plexus/plexus-component-api.spec
SRPM URL: http://yyang.fedorapeople.org/plexus/plexus-component-api-1.0-0.1.alpha15.src.rpm


FYI the different line in http://overholt.fedorapeople.org/plexus-component-api-1.0-alpha-15.diff:
- * @version CVS $Revision: 4796 $ $Date: 2006-11-24 05:24:11 +0800 (Fri, 24 Nov 2006) $
+ * @version CVS $Revision: 4796 $ $Date: 2006-11-23 16:24:11 -0500 (Thu, 23 Nov 2006) $

Created attachment 411629 [details]
suggested fixes

It looks good, thanks for the fixes.  Please drop the blank line immediately following %changelog.

There are two remaining rpmlint issues:

plexus-component-api.noarch: W: incoherent-version-in-changelog 0:1.0-0.1.alpha15 ['1.0-0.1.alpha15.fc12', '1.0-0.1.alpha15']
plexus-component-api.noarch: W: no-documentation
plexus-component-api.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-component-api
plexus-component-api.noarch: W: dangling-relative-symlink /usr/share/java/plexus-component-api-1.0-alpha-15.jar *-%{prject_version}*

You need something like the attached diff.

Also, I see that we have /usr/share/java/plexus.  Please put the JARs in there.

Fixed: 1.incoherent-version-in-changelog;2.drop the blank line immediately
following %changelog;3.typo %{prject_version}; 4. jars to plexus directory


Please review again.

Spec URL: http://yyang.fedorapeople.org/plexus/plexus-component-api.spec
SRPM URL:
http://yyang.fedorapeople.org/plexus/plexus-component-api-1.0-0.1.alpha15.src.rpm

I still get incoherent-version-in-changelog.  Are we running the same rpmlint?

$ rpmlint -V
rpmlint version 0.95 Copyright (C) 1999-2007 Frederic Lepied, Mandriva

Other than the incorrect version in %changelog, things are fine.  Correct that and this will be approved.  Thanks.

I have upgraded rpmlint to 0.91 which is the latest version I can find for RHEL5.

FYI:
---
[yyang@localhost SPECS]$ rpmlint -V
rpmlint version 0.91 Copyright (C) 1999-2007 Frederic Lepied, Mandriva
[yyang@localhost SPECS]$ rpmlint plexus-component-api.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
---

Please review again.
Spec URL: http://yyang.fedorapeople.org/plexus/plexus-component-api.spec
SRPM URL:
http://yyang.fedorapeople.org/plexus/plexus-component-api-1.0-0.1.alpha15.src.rpm

If you still get "incorrect version in %changelog", could you please help look into the SPEC file, and tell me how to fix it, many thanks.

Please, also add necessary requires for owner of the used directories - jpackage-utils (owner of %{_mavenpomdir}, %{_mavendepmapfragdir} and %{_javadocdir}).

Unfortunately, due to overall poor quality of java-related packages. I can't find who is an owner of %{_javadocdir}/plexus/ and %{_javadir}/plexus. I've got numerous matches, but don't have enough knowledge to pick correct one.

Thanks, Yong, that rpmlint error is gone now.

Peter, thanks for bringing up the issue with directory ownership.  Everyone appreciates your help in getting the packages into a better state so please continue helping in this area :)

Yong, please do as Peter asks and add jpackage-utils as a Requires.  While the chain of dependencies would take care of this, it's just as valid to have the direct Requires.  Thanks.

Added 3 Requires
Requires:          java >= 1:1.6.0
Requires:          plexus-utils
Requires:          jpackage-utils

Please review again.
Spec URL: http://yyang.fedorapeople.org/plexus/plexus-component-api.spec
SRPM URL:
http://yyang.fedorapeople.org/plexus/plexus-component-api-1.0-0.1.alpha15.src.rpm

for directories %{_javadocdir}/plexus/ and %{_javadir}/plexus, I guess plexus-utils is the correct owner.

Thanks, Yong.  Everything is now okay so this package is APPROVED.  Please follow the next steps here:

https://fedoraproject.org/wiki/Package_Review_Process#Review_Process

New Package CVS Request
=======================
Package Name: plexus-component-api
Short Description: Plexus Component API
Owners: yyang
Branches: devel
InitialCC: overholt huwang liweinan

CVS Done

Koji build:
http://koji.fedoraproject.org/koji/packageinfo?packageID=10364