Bug 588771

Summary:	Double clicking a disk in the right clear disk pane also clears the bootdev selection
Product:	[Fedora] Fedora	Reporter:	Hans de Goede <hdegoede>
Component:	anaconda	Assignee:	Chris Lumens <clumens>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	13	CC:	jlaska, jonathan, vanmeeuwen+fedora
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	anaconda-14.5-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-07-01 20:58:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Hans de Goede 2010-05-04 13:38:24 UTC

To reproduce:

1) Do an interactive install on a machine with at least 3 disks
2) Select all 3 disks in the filter UI
3) In the clear disk UI move all disks to the right pane
4) double click on a disk in the right pane which is not selected as
   bootdevice

Result:
The disk which is double clicked gets moved to the left pane (ok) and
the disk which was selected as bootdevice is no longer selected as
bootdevice (not ok)

Expected:
The disk which is double clicked gets moved to the left pane, no other
changes.


Note we may want to fix this for RHEL-6 too.

Comment 1 Chris Lumens 2010-05-04 19:07:36 UTC

DOES NOT reproduce:

(1) Select all three devices in the left hand side and move to the right.
(2) Double click on a device in the right hand side which is not the boot device.


DOES reproduce:

(1) Select all three devices in the left hand side and move to the right.
(2) Change which device is selected as the boot device via the radio button.
(3) Double click on a device in the right hand side which is not the boot device.

Does this match up with what you guys are seeing?  A related problem here is if you double click on the boot device in the right hand side, no other device gets selected for you.  Is that actually a problem?

Comment 2 James Laska 2010-05-04 19:29:16 UTC

(In reply to comment #1)
> DOES NOT reproduce:
> 
> (1) Select all three devices in the left hand side and move to the right.
> (2) Double click on a device in the right hand side which is not the boot
> device.

My experiences match yours.  I've retested with 2 devices.  Double clicking (without changing the default boot device), does not trigger the reported behavior.

> DOES reproduce:
> 
> (1) Select all three devices in the left hand side and move to the right.
> (2) Change which device is selected as the boot device via the radio button.
> (3) Double click on a device in the right hand side which is not the boot
> device.

My experiences match yours.  Using the procedure above, I'm able to trigger the reported behavior.
 
> Does this match up with what you guys are seeing?  A related problem here is if
> you double click on the boot device in the right hand side, no other device
> gets selected for you.  Is that actually a problem?    

I don't think that's bad, just as long as the UI doesn't allow you to proceed until *something* is selected.

Comment 3 Hans de Goede 2010-05-04 19:43:18 UTC

(In reply to comment #1)
> DOES NOT reproduce:
> 
> (1) Select all three devices in the left hand side and move to the right.
> (2) Double click on a device in the right hand side which is not the boot
> device.
> 
> 
> DOES reproduce:
> 
> (1) Select all three devices in the left hand side and move to the right.
> (2) Change which device is selected as the boot device via the radio button.
> (3) Double click on a device in the right hand side which is not the boot
> device.
> 

Ah, it could very well be that is actually what I was seeing. I believe you when you say that this does not happen when the default boot device is selected.

> Does this match up with what you guys are seeing?  A related problem here is if
> you double click on the boot device in the right hand side, no other device
> gets selected for you.  Is that actually a problem?    

Yes and no, if the default boot device gets removed by double clicking no device should be selected for booting (if the system is not going to boot from bios dev 80, no guess is better then a random guess). OTOH if a device which is not the default boot device, but was selected for boot gets removed the default boot device should be selected. IOW after the double click _autoSelectBootDisk() should be called (it is a no-op if some device is already selected).