|Summary:||Review Request: perl-Test-POE-Server-TCP - POE Component providing TCP server services for test cases|
|Product:||[Fedora] Fedora||Reporter:||Yanko Kaneti <yaneti>|
|Component:||Package Review||Assignee:||Marcela Mašláňová <mmaslano>|
|Status:||CLOSED RAWHIDE||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Fixed In Version:||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2011-08-30 10:54:03 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Cloudforms Team:||---||Target Upstream Version:|
Description Yanko Kaneti 2010-05-06 08:59:52 UTC
Spec URL: http://declera.com/~yaneti/perl-Test-POE-Server-TCP/perl-Test-POE-Server-TCP.spec SRPM URL: http://declera.com/~yaneti/perl-Test-POE-Server-TCP/perl-Test-POE-Server-TCP-1.10-1.fc14.src.rpm Description: Test::POE::Server::TCP is a POE component that provides a TCP server framework for inclusion in client component test cases, instead of having to roll your own. This happens to be a build requirement for some other POE components that are already in the distribution.
Comment 1 Marcela Mašláňová 2010-05-07 07:45:40 UTC
Almost good ;-) Only few comments: Remove this, MODULE_COMPAT it's enough -> BuildRequires: perl >= 1:5.6.0 Also do you need all requires? Don't they needed only as BuildRequires? Change PERL_INSTALL_ROOT to DESTDIR, because this bug wasn't still removed from cpanspec ;-) None of these are blockers. Please fix it before upload. ACCEPTED
Comment 2 Yanko Kaneti 2010-05-07 10:37:04 UTC
(In reply to comment #1) > Remove this, MODULE_COMPAT it's enough -> BuildRequires: perl >= 1:5.6.0 For this I've decided to stay with the Perl packaging guidelines for now. http://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires Once they are revised some automated tool would probably be used to remove that line for all modules. > Also do you need all requires? Don't they needed only as BuildRequires? It doesn't seem the perl autorequires work for usage declarations like the one that can be found in /usr/share/perl5/Test/POE/Server/TCP.pm use POE qw(Wheel::SocketFactory Wheel::ReadWrite Filter::Line); If not explicitly declared the built package ends without requirements for these. I've only removed the superfluous BuildRequires: perl(POE::Filter) > Change PERL_INSTALL_ROOT to DESTDIR, because this bug wasn't still removed from > cpanspec ;-) Done > None of these are blockers. Please fix it before upload. > > ACCEPTED Thanks! New Package CVS Request ======================= Package Name: perl-Test-POE-Server-TCP Short Description: POE Component providing TCP server services for test cases Owners: yaneti Branches: F-13 InitialCC: perl-sig
Comment 3 Kevin Fenzi 2010-05-09 02:09:27 UTC
CVS done (by process-cvs-requests.py).
Comment 4 Yanko Kaneti 2010-05-09 05:40:59 UTC
Imported. Builds done. Bodhi update for F-13 submitted. Thanks.
Comment 5 Yanko Kaneti 2011-08-28 15:48:34 UTC
Package Change Request ====================== Package Name: perl-Test-POE-Server-TCP New Branches: el6 Owners: remi
Comment 6 Gwyn Ciesla 2011-08-29 11:57:58 UTC
Git done (by process-git-requests).