Bug 589479

GOOD:
+ Package name fullfill naming guidelines.
+ URL tag contains proper project home page.
+ Package contains most recent release of the software.
+ Could download source file via spectool -g
+ Consistantly rpm macro usages.
+ License tag contains proper OSS licenses
+ Package has proper BuildRoot definition.
+ Package contains versioned MODULE_cOMPAT_ Req.
+ Package contains no subpackages
+ Build use RPM_OPT_FLAGS
+ Build use SMP flags
+ Local build works fine.
+ Mockbuild works fine.
+ Build on koji works fine.
+ Packaged sources matches with upstream.
* Rpmlint has no complains about the binary package
+ Rpmlint has no complains about the debuginfo package
+ Debuginfo package contains sources
+ %files stanza use rpm macros
+ %files has proper attributes
+ All files of the package belong to the package
+ Package contains no files belog to an other package
+ %doc stanza is small, so we ne no extra doc subpackage
+ Package has proper %ChangeLog

BAD:
- Package contains no verbatin copy of the license text.
- Package has no %clean section, so it's only valid for F-13 and devel
- Rpmlint shows warnings for the source RPM_OPT_FLAGS$ rpmlint perl-Compress-Raw-Lzma-2.028-1.fc12.src.rpm 
perl-Compress-Raw-Lzma.src: W: no-cleaning-of-buildroot %clean
perl-Compress-Raw-Lzma.src: W: no-%clean-section
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

-

- Package contains no verbatim copy of the license text.

The upstream tarball doesn't contain one, as usual for perl modules. The license terms are clearly stated as "same as perl" in the code itself though.

- Package has no %clean section, so it's only valid for F-13 and devel
- Rpmlint shows warnings for the source RPM_OPT_FLAGS$ rpmlint
perl-Compress-Raw-Lzma-2.028-1.fc12.src.rpm 
perl-Compress-Raw-Lzma.src: W: no-cleaning-of-buildroot %clean
perl-Compress-Raw-Lzma.src: W: no-%clean-section
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

These are intended. The only current user of Compress::Raw::Lzma is IO::Compress::Lzma (see Bug #589482) and that requires IO::Compress::Base >= 2.027, which only went into Rawhide today. I don't expect to be building this for F-12 or earlier releases any time soon, especially since IO::Compress::Base is a core module and unlikely to be updated there unless there's a real bug.

Upstream update:

Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Compress-Raw-Lzma/branches/fedora/perl-Compress-Raw-Lzma.spec

SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Compress-Raw-Lzma/perl-Compress-Raw-Lzma-2.029-1.fc14.src.rpm

Bood:
+ Could download upstream sources via spectool -g
+ Packaged sources matches with updateam
(md5sum: 96ed2d92d64c911e4c5e0b6cdd34f13b)
+ Local build works fine
+ Build honours RPM_OPT_FLAGS
+ Build is SMP compilant
+ Scratch build on koji works fine

*** APPROVED for devel and F-13 ***

New Package CVS Request
=======================
Package Name: perl-Compress-Raw-Lzma
Short Description: Low-level interface to lzma compression library
Owners: pghmcfc
Branches: F-13
InitialCC: perl-sig

CVS done (by process-cvs-requests.py).

Remember to assign the review to the package reviewer. ;)

perl-Compress-Raw-Lzma-2.029-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-Compress-Raw-Lzma-2.029-2.fc13

perl-Compress-Raw-Lzma-2.029-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

All done; thanks for the review Jochen.