Bug 589585
Summary: | Review Request: maven-javadoc-plugin - Maven Javadoc plugin | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mary Ellen Foster <mefoster> |
Component: | Package Review | Assignee: | Jeff Johnston <jjohnstn> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | akurtako, fedora-package-review, jjohnstn, notting |
Target Milestone: | --- | Flags: | jjohnstn:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-05-11 15:32:00 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mary Ellen Foster
2010-05-06 13:40:38 UTC
Additional note: this builds successfully in koji against the dist-f14-maven221 target: http://koji.fedoraproject.org/koji/taskinfo?taskID=2167910 Please provide URL of where the tarball was taken from or else information about how the tarball was created. If it was a snapshot from a repository, please indicate that with either the date or tag used. Results of rpmlint on build above. Please fix where appropriate and/or comment as ignored for the messages below. bash $ rpmlint -i maven-javadoc-plugin-2.4-1.1.fc14.noarch.rpm maven-javadoc-plugin.noarch: W: spelling-error %description -l en_US javadocs -> java docs, java-docs, Javanese The value of this tag appears to be misspelled. Please double-check. maven-javadoc-plugin.noarch: E: no-changelogname-tag There is no %changelog tag in your spec file. To insert it, just insert a '%changelog' in your spec file and rebuild it. maven-javadoc-plugin.noarch: W: obsolete-not-provided maven2-plugin-javadoc If a package is obsoleted by a compatible replacement, the obsoleted package should also be provided in order to not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the Provides. maven-javadoc-plugin.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. maven-javadoc-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-javadoc-plugin A non-executable file in your package is being installed in /etc, but is not a configuration file. All non-executable files in /etc should be configuration files. Mark the file as %config in the spec file. 1 packages and 0 specfiles checked; 1 errors, 4 warnings. *-javadoc package must require jpackage-utils (owner of %{_javadocdir}), which is a common packaging issue among java-related packages. I've fixed the issues identified in the above comments (the missing changelog was an artifact of the build, which wasn't quite the final version). - Added jpackage requirements - Updated requirements of the (disabled) jpackage sub-package - Added a comment showing where the tarball comes from (it's a subversion checkout, so no URL is possible) - Added a Provides: maven2-plugin-javadoc - The warning about /etc/maven/fragments/maven-javadoc-plugin not being a conf-file is spurious http://www.macs.hw.ac.uk/~mef3/maven221/maven-javadoc-plugin.spec http://www.macs.hw.ac.uk/~mef3/maven221/maven-javadoc-plugin-2.4-2.fc12.src.rpm p.s. -- Here's a new koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2171528 Looks good. I am marking this as reviewed. New Package CVS Request ======================= Package Name: maven-javadoc-plugin Short Description: Maven Javadoc plugin Owners: mef Branches: InitialCC: CVS done (by process-cvs-requests.py). |