Bug 589705
| Summary: | Update R template | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre-YvesChibon <pingou> | ||||
| Component: | rpmdevtools | Assignee: | Ville Skyttä <ville.skytta> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | herrold, ville.skytta | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 7.9-1 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-05-20 20:37:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 593363 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
FYI, I kept in the template:
%global packname %(echo %{name} | sed -e 's/^R-//')
although it does not work for me here (but I guess this should be a different bug)
I redid the patch because the one in initial comment contained apparently whitespace only changes that I don't think belong in the template (for consistency with others) and make it harder to see what's going on with the changes, please take a look at the git version to see if I missed something (and if I did, patches against that version are welcome). http://git.fedorahosted.org/git/?p=rpmdevtools.git;a=summary Fixes also welcome to the %global packname thing if the current thing doesn't work. Looks good to me (pity for the spaces though, I liked when headers are aligned). I have been discussing regarding: %ifarch noarch Requires: R-core %endif It could be changed to a simple Requires: R-core # only needed for noarch For the packname I'll see if I find something. http://git.fedorahosted.org/git/?p=rpmdevtools.git;a=commitdiff;h=594de67423252e833f987e048574e5d8974543f8 (Again for consistency with other spec templates) I'll put this back to NEEDINFO regarding the packname issue. I took a look at the packname issue and I now believe it is a problem in rpm, see bug 593363. One workaround seems to be to use %define instead of %global. rpmdevtools-7.10-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rpmdevtools-7.10-1.fc13 rpmdevtools-7.10-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 412132 [details] Patch to change the template to the latest guidelines Description of problem: The R template is outdated. I am attaching to this bug a patch to correct the template to the latest version of the packaging guidelines.