Bug 589739

Summary: CPUSCALING test includes unprocessed tags around displayed text
Product: [Retired] Red Hat Hardware Certification Program Reporter: Gary Case <gcase>
Component: Test Suite (tests)Assignee: Greg Nichols <gnichols>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.1CC: czhang, rlandry, sdenham, yuchen
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
In v7 1.1, unprocessed tags were displayed in running output during cpuscaling test. This issue has been fixed in v7 1.3, now cpuscaling test output does not contain any unprocessed tags around displayed text.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-09 16:14:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
hardwaretest.patch moving from "make run" to direct test call
none
New Log class to manage test output
none
test.py patch changing XML tagging out test output logs
none
tests directory patch removing unused testinfo.desc generation none

Description Gary Case 2010-05-06 19:27:32 UTC 
Description of problem:
The CPUSCALING test displays tags that shouldn't be seen while it's running.

Version-Release number of selected component (if applicable):
v7 1.1-23

How reproducible:
always

Steps to Reproduce:
1. Run CPUSCALING test
2.
3.
  
Actual results:

After tests, you can see
<summary>PASS</summary>
</output>
Current load average: 
<output name="On Demand" description="None">
<output name="User Space" description="None">
<output name="On Demand" description="None">
You can also see 

<output>

<output name="Capabilities" description=None>

...finished running ./cpuscaling.py, exit code=0
</output>
recovered exit code=0

Expected results:
Hidden output should be hidden

Additional info:
Comment 1 Greg Nichols 2010-05-06 20:08:24 UTC 
These tags are expected as part of the implementation of subtest marking in the current implementation.    They're a consequence of the current implementation that runs test via a separate shell ("make run" which invokes the tests' python code).  We should be able to clean this up when v7's implementation changes to call test code directly via python function call to the test code.
Comment 3 Greg Nichols 2011-01-26 14:26:37 UTC 
Created attachment 475399 [details]
hardwaretest.patch moving from "make run" to direct test call

This patch changes v7 to directly call the "run" function of each test, rather than the old method of calling "make run" within the test directory.  This change allows control over test logging so that logs can be XML, while console output can be regular text without XML tagging.
Comment 4 Greg Nichols 2011-01-26 14:28:58 UTC 
Created attachment 475400 [details]
New Log class to manage test output

The new Log class replaces use of "tee" within a shell for logging test output to stdout, as well as displaying it on a terminal.  The Log class assigns to sys.stdout and sys.stderr, effectively redirecting stdout to a Log object, we sends output to the file, and the console.
Comment 5 Greg Nichols 2011-01-26 14:31:27 UTC 
Created attachment 475401 [details]
test.py patch changing XML tagging out test output logs

This patch to test.py changes code used by tests to mark test subsections with XML so that the tags are only sent to the log file, and not to the console.
Comment 8 Greg Nichols 2011-01-28 14:59:42 UTC 
Created attachment 475815 [details]
tests directory patch removing unused testinfo.desc generation
Comment 11 Caspar Zhang 2011-04-30 08:01:04 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
In v7 1.1, unprocessed tags were displayed in running output during cpuscaling test. This issue has been fixed in v7 1.3, now cpuscaling test output does not contain any unprocessed tags around displayed text.
Comment 12 Caspar Zhang 2011-04-30 08:17:43 UTC 
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-In v7 1.1, unprocessed tags were displayed in running output during cpuscaling test. This issue has been fixed in v7 1.3, now cpuscaling test output does not contain any unprocessed tags around displayed text.+In v7-1.1, unprocessed tags were displayed in running output during cpuscaling test. This issue has been fixed in v7-1.3, now cpuscaling test output does not contain any unprocessed tags around displayed text.
Comment 13 Caspar Zhang 2011-04-30 08:18:27 UTC 
    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-In v7-1.1, unprocessed tags were displayed in running output during cpuscaling test. This issue has been fixed in v7-1.3, now cpuscaling test output does not contain any unprocessed tags around displayed text.+In v7 1.1, unprocessed tags were displayed in running output during cpuscaling test. This issue has been fixed in v7 1.3, now cpuscaling test output does not contain any unprocessed tags around displayed text.
Comment 14 errata-xmlrpc 2011-05-09 16:14:32 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0497.html