Bug 590024
| Summary: | Review Request: urbi-sdk - Robotics development platform | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Moulard <thomas.moulard> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-29 22:16:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Thomas Moulard
2010-05-07 14:31:12 UTC
The only serious problem detected by rpmlint is that shared libraries are named lib<LIBRARY>.so without any versioning. $ rpmlint ~/rpmbuild/RPMS/i686/urbi-sdk-2.0.2-1.fc12.i686.rpm 64 16:43:17 urbi-sdk.i686: E: invalid-soname /usr/lib/libsched.so libsched.so urbi-sdk.i686: W: shared-lib-calls-exit /usr/lib/libsched.so exit urbi-sdk.i686: W: executable-stack /usr/lib/libsched.so urbi-sdk.i686: E: invalid-soname /usr/lib/libjpeg4urbi.so libjpeg4urbi.so urbi-sdk.i686: W: shared-lib-calls-exit /usr/lib/libjpeg4urbi.so exit urbi-sdk.i686: E: invalid-soname /usr/lib/liburbi.so liburbi.so urbi-sdk.i686: W: shared-lib-calls-exit /usr/lib/liburbi.so exit urbi-sdk.i686: E: invalid-soname /usr/lib/libport.so libport.so urbi-sdk.i686: W: shared-lib-calls-exit /usr/lib/libport.so exit urbi-sdk.i686: E: invalid-soname /usr/lib/libserialize.so libserialize.so $ rpmlint ~/rpmbuild/RPMS/i686/urbi-sdk-devel-2.0.2-1.fc12.i686.rpm 64 16:43:53 urbi-sdk-devel.i686: W: no-documentation Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2172508 New Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2172545 I have updated the spec file. One build requirement was missing. Build fails for me:
In file included from ./include/libport/intrusive-ptr.hh:180:0,
from ./include/libport/deref.hh:22,
from lib/libport/deref.cc:16:
./include/libport/intrusive-ptr.hxx: In member function 'void libport::intrusive_ptr<T>::serialize(Archive&, unsigned int)':
./include/libport/intrusive-ptr.hxx:241:5: error: 'split_member' is not a member of 'boost::serialization'
make[5]: *** [lib/libport/lib_libport_libport_la-deref.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
In file included from ./include/libport/intrusive-ptr.hh:180:0,
from ./include/libport/destructible.hh:14,
from ./include/libport/asio.hh:44,
from lib/libport/asio.cc:15:
./include/libport/intrusive-ptr.hxx: In member function 'void libport::intrusive_ptr<T>::serialize(Archive&, unsigned int)':
./include/libport/intrusive-ptr.hxx:241:5: error: 'split_member' is not a member of 'boost::serialization'
make[5]: *** [lib/libport/lib_libport_libport_la-asio.lo] Error 1
A koji scratch build is at http://koji.fedoraproject.org/koji/taskinfo?taskID=2617977
The "executable-stack" rpmlint complaint above, by the way, is actually quite problematic as it will prevent the software from running with selinux enabled.
Finally, without any way for a reviewer to download the source, I really doubt anyone will review this. You need to at least provide directions for obtaining it, although I still don't think most potential reviewers would be willing to register somewhere.
|