Bug 59016
| Summary: | /usr/bin/foomatic-combo-xml does not close files | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Alain D D Williams <addw> |
| Component: | foomatic | Assignee: | Tim Waugh <twaugh> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Aaron Brown <abrown> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.2 | ||
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2002-01-29 17:48:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Do you have the printing updates applied? This should already be fixed. I have updated with printconf-0.3.52-1.i386.rpm &
printconf-gui-0.3.52-1.i386.rpm.
It still does it.
Appended is part of the strace, you will see that it does attempt to close, but
seems to be closing some random value rather than the proper file descriptor:
25569 open("/usr/share/foomatic/db/source/printer/Sharp-AJ-2100.xml", O_RDONLY)
= 991
25569 fstat64(991, {st_mode=S_IFREG|0644, st_size=846, ...}) = 0
25569 mmap2(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0)
= 0x4052f000
25569 read(991, "\n<printer id=\"printer/Sharp-AJ-2"..., 1048576) = 846
25569 read(991, "", 1044480) = 0
25569 brk(0x8104000) = 0x8104000
25569 read(991, "", 1048576) = 0
25569 close(135277528) = -1 EBADF (Bad file descriptor)
25569 open("/usr/share/foomatic/db/source/printer/Star-JJ-100.xml", O_RDONLY) =
992
Please confirm the version of foomatic that you are using. Just before that last comment I applied both: Omni-foomatic-0.5.0-4.i386.rpm & Omni-0.5.0-4.i386.rpm (as well as ghostscript-6.51-16.i386.rpm) since printconf-0.3.52 depends on all of these RPMs. These are, however, the only updates on what is otherwise a vanilla 7.2 system. (Others will be applied over the next few days as I make it ready for production). Not Omni-foomatic, foomatic. What does 'rpm -q foomatic' say? rpm -q foomatic gives: foomatic-1.1-0.20010905.1 I noticed foomatic-1.1-0.20011018.7.i386.rpm, installed it and ran the test again. It is now fixed, opening those files of fd 4. So cured. Thanks for your time, sorry if it was wasted. |
From Bugzilla Helper: User-Agent: Mozilla/4.76 [en] (X11; U; Linux 2.2.14-12b i686) Description of problem: Run printtool under 'strace -f' and you will see that the file number returned by open() gets to be very large (956 on my box). It seems as if the program is not closing files once it has read them, not good practice. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. strace -f -o /tmp/trout printtool 2. Just close printtool down 3. emacs /tmp/trout Look for: open("/usr/share/foomatic/db/source/printer/HP-DeskJet_816 and note the file number returned. Expected Results: The file descriptor should be a much smaller number. Additional info: