Bug 590460

Created attachment 412660 [details]
proposed patch

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Can you get this patch in through transifex?  Make sure it gets applied to both rhel6-branch and master.  Thanks.

This patch is small enough that I think we can just toss it in for master and rhel6-branch.

(In reply to comment #3)
> Can you get this patch in through transifex?  Make sure it gets applied to both
> rhel6-branch and master.  Thanks.    
Is this a needinfo from me? I am not familiar with transifex.

Fixed po files were submitted to master and thel6 branches.

Thanks for reporting.

This issue has been proposed when we are only considering blocker
issues in the current Red Hat Enterprise Linux release. It has
been denied for the current Red Hat Enterprise Linux release.

** If you would still like this issue considered for the current
release, ask your support representative to file as a blocker on
your behalf. Otherwise ask that it be considered for the next
Red Hat Enterprise Linux release. **

Note, this is still an issue as far as I can tell. It looks like a transifex commit dce88c8b un-did the change that Tommy made.

This issue has been proposed when we are only considering blocker
issues in the current Red Hat Enterprise Linux release. It has
been denied for the current Red Hat Enterprise Linux release.

** If you would still like this issue considered for the current
release, ask your support representative to file as a blocker on
your behalf. Otherwise ask that it be considered for the next
Red Hat Enterprise Linux release. **

(In reply to comment #9)
> Note, this is still an issue as far as I can tell. It looks like a transifex
> commit dce88c8b un-did the change that Tommy made.    

OK...what should I do now? Rolling back the commit?

Hi all,

Since it's a translation issue, it has to go through proper channel (localization team -> zh_CN translator).

Assigning it to Leah Liu, who's in charge of handling zh_CN translations. She will take the necessary actions.

Thanks!
Ankit

The translation is modified to '提交' as the word 'File' here is a verb instead of noun.

Thanks
Leah

FIXED.

rhel6-branch: https://translate.fedoraproject.org/projects/p/anaconda/c/rhel6-branch/view/po/zh_CN.po

master branch: https://translate.fedoraproject.org/projects/p/anaconda/c/master/view/po/zh_CN.po

Thanks!
Ankit

if there is some problem with zh-CN, Leah Liu is still in the CC watch list.

The zh_CN.po file has been broken recently and we have to either revert the changes or fix up the file so the builds can complete.

The problem that keeps happening is for plural format strings where there is a singular and plural translation choice.  For example, line 575 in po/zh_CN.po keeps breaking.  Here is what ends up in the translation file:

#: installinterfacebase.py:47
#, python-format
msgid ""
"Disk %s contains BIOS RAID metadata, but is not part of any recognized BIOS "
"RAID sets. Ignoring disk %s."
msgid_plural ""
"Disks %s contain BIOS RAID metadata, but are not part of any recognized BIOS "
"RAID sets. Ignoring disks %s."
msgstr[0] ""
"磁盘 %s 中包含 BIOS RAID 元数据，但该数据不包含在任何可识别 BIOS 组中。"
"忽略磁盘 %s。"
msgstr[1] ""
""

The problem here is the msgstr[1] part.  You cannot have "" as the string because the msgid has format strings in it.  Even if the string is the same for this language, it needs to be duplicated.  Copying the string from msgstr[0] to msgstr[1] allows our build to complete, so we change it to:

msgstr[1] ""
"磁盘 %s 中包含 BIOS RAID 元数据，但该数据不包含在任何可识别 BIOS 组中。"
"忽略磁盘 %s。"

Please make sure that translations are complete when you commit them to the git repository.  We cannot continue to fix up the po files, we will have to start reverting changes to ensure the builds succeed.

(In reply to comment #17)
> The zh_CN.po file has been broken recently and we have to either revert the
> changes or fix up the file so the builds can complete.
> 
> The problem that keeps happening is for plural format strings where there is a
> singular and plural translation choice.  For example, line 575 in po/zh_CN.po
> keeps breaking.  Here is what ends up in the translation file:
> 
> #: installinterfacebase.py:47
> #, python-format
> msgid ""
> "Disk %s contains BIOS RAID metadata, but is not part of any recognized BIOS "
> "RAID sets. Ignoring disk %s."
> msgid_plural ""
> "Disks %s contain BIOS RAID metadata, but are not part of any recognized BIOS "
> "RAID sets. Ignoring disks %s."
> msgstr[0] ""
> "磁盘 %s 中包含 BIOS RAID 元数据，但该数据不包含在任何可识别 BIOS 组中。"
> "忽略磁盘 %s。"
> msgstr[1] ""
> ""
> 
> The problem here is the msgstr[1] part.  You cannot have "" as the string
> because the msgid has format strings in it.  Even if the string is the same for
> this language, it needs to be duplicated.  Copying the string from msgstr[0] to
> msgstr[1] allows our build to complete, so we change it to:
> 
> msgstr[1] ""
> "磁盘 %s 中包含 BIOS RAID 元数据，但该数据不包含在任何可识别 BIOS 组中。"
> "忽略磁盘 %s。"
> 
> Please make sure that translations are complete when you commit them to the git
> repository.  We cannot continue to fix up the po files, we will have to start
> reverting changes to ensure the builds succeed.    


HI David,

Perhaps you haven't synched the zh_CN.po file from the git repo (rhel6-branch). Could you please check again. Because the corrected file is already submitted by Leah Liu this morning.

See the commit diff: http://git.fedorahosted.org/git/?p=anaconda.git;a=commitdiff;h=6ef0e970bfa1e180219a9a36e2fa9975c8b83c42
and the actual file: https://translate.fedoraproject.org/projects/p/anaconda/c/rhel6-branch/view/po/zh_CN.po

Thanks!
Ankit

We pull all updated translations automatically before doing builds, so this will get pulled in.  I did a test build and it looks good now.  Thanks for fixing.

Looks like the zh_CN changes were pushed after we built yesterday (which makes sense given the time zones that we all work in).  The updated zh_CN.po file will be in the next build, which will be anaconda-13.21.68-1.

Hi I am trying to verify this translation.

Which screen are you mentioning this bug?

Can you tell me the steps to verify?

Created attachment 438813 [details]
zh_CN - Screenshot FIXED word

status - FIXED
tested package: anaconda-13.21.74-1.el6.x86_64

detail: Screenshot

Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.