Bug 590522

You haven't put links to your spec and srpm.

Created attachment 412735 [details]
spec file

Created attachment 412737 [details]
SRPM

(In reply to comment #0)
> Spec URL: http://hotfile.com/dl/42162162/56b2406/plexus-cipher.spec.html
> SRPM URL: http://hotfile.com/dl/42162040/79e5c4c/plexus-cipher-1.4-1.src.rpm.html
> Description: Plexus Cipher: encryption/decryption Component

I will take this.

I'm happy for you to continue putting your SPEC and SRPM on the bug as attachments, by the way. :-)

Those parent poms, are there any other plexus modules that might need these to build? I'm just wondering if it is worth getting these poms into the maven2-common-poms package like we did with the Apache commons-parent pom...

(In reply to comment #6)
> Those parent poms, are there any other plexus modules that might need these to
> build? I'm just wondering if it is worth getting these poms into the
> maven2-common-poms package like we did with the Apache commons-parent pom...    

Could be useful, take a look here -> bug 591454

Ah, well spotted. Huwang, what do you think about making this depend on the spice-parent package instead of bundling the pom here?

(In reply to comment #8)
> Ah, well spotted. Huwang, what do you think about making this depend on the
> spice-parent package instead of bundling the pom here?    

There are 3 modules depend on spice-parent package: plexus-cipher, plexus-build-api and plexus-sec-dispatcher. So I added spice-parent package which is only a pom file.

Excellent, please update your SPEC/SRPM and I will conduct a full review.

huwang, Please do what Mat requested

(In reply to comment #10)
> Excellent, please update your SPEC/SRPM and I will conduct a full review.    

Sorry for the delay, as I updated it to the latest version, please review again, thanks a lot.

spec URL: http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=plexus-cipher.spec&can=2&q=#makechanges

SRPM URL:  http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=plexus-cipher-1.5-1.src.rpm&can=2&q=#makechanges

Note about this package:
 It built with dist-f14-maven221 target, koji building link is http://koji.fedoraproject.org/koji/taskinfo?taskID=2198806

Rebuilt in koji with dist-f14-maven221 target, the link is http://koji.fedoraproject.org/koji/taskinfo?taskID=2198918

Hmm, I rebuilt your SPRM again myself, and this time it failed:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2200828

Also, in both our builds, it fails to get this pom file:
JPP/maven2/default_poms/JPP-apache-commons-logging.pom

Seems like it should be finding this one first anyway:
JPP/maven2/poms/JPP-commons-logging.pom

What's going on there?

Also, please provide a valid url in the spec file URL tag.

I am sorry, this is actually a problem in commons-logging. I am fixing it right now. Sorry for causing trouble...

No problem, thanks for your attention Stanislav :-)

Just to explain (might be useful for future):
One of the dependencies that plexus-cipher pulls in is using old jakarta-commons-logging package I assume. It had wrong groupId (commons-logging instead of org.apache.commons) so I had to fix it when I renamed package to apache-commons-logging. I tried to keep backward compatibility but I forgot to change one call to use correct name...

Ok the commons-logging thing has been fixed, but it still fails to build for me:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2201405


[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Internal error in the plugin manager executing goal 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc': Unable to find the mojo 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc' in the plugin 'org.apache.maven.plugins:maven-javadoc-plugin'
org.apache.maven.doxia.logging.LogEnabled
[INFO] ------------------------------------------------------------------------


I'm not sure what "Unable to find the mojo" means, is it a problem with this package or a problem in the maven javadoc plugin?

(In reply to comment #18)
> Ok the commons-logging thing has been fixed, but it still fails to build for
> me:
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=2201405
> 
> 
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD ERROR
> [INFO] ------------------------------------------------------------------------
> [INFO] Internal error in the plugin manager executing goal
> 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc': Unable to find the
> mojo 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc' in the plugin
> 'org.apache.maven.plugins:maven-javadoc-plugin'
> org.apache.maven.doxia.logging.LogEnabled
> [INFO] ------------------------------------------------------------------------
> 
> 
> I'm not sure what "Unable to find the mojo" means, is it a problem with this
> package or a problem in the maven javadoc plugin?    

I think this isn't this package's problem. I built again, it isn't failed, the link is http://koji.fedoraproject.org/koji/taskinfo?taskID=2207394

spec URL:
http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=plexus-cipher.spec&can=2&q=#makechanges

SRPM URL: 
http://code.google.com/p/tobepackagemaintaner/downloads/detail?name=plexus-cipher-1.5-1.src.rpm&can=2&q=#makechanges

please review again, thanks.

Mat, 
Can you finish this?
If not please drop yourself and I'll do it. It's blocking other packages.

Sorry, I have been very busy this week. I can finish it at the weekend, if that is ok.

Hi,

This builds for me now finally, thanks.

Rpmlint output:

  W: spelling-error Summary(en_US) decryption
  W: spelling-error %description -l en_US decryption

Ignore these spelling warnings, "decryption" is a valid noun form of the verb "decrypt." What a terrible dictionary it's using.

  W: non-conffile-in-etc /etc/maven/fragments/plexus-cipher

This is normal and may also be ignored.

  W: no-documentation

Please include the NOTICE.txt file as documentation in the main package.

  W: invalid-url URL: http://spice.sonatype.org/plexus-cipher HTTP Error 404: Not Found
  W: invalid-url URL: http://spice.sonatype.org/plexus-cipher HTTP Error 404: Not Found

Please include a valid URL in the URL tag. I've tried this in my browser, there is definitely no page at this location.

---

I've been through the guidelines and the review check list and I believe the package is acceptable except for the two items from the rpmlint output that I've highlighted above.

(In reply to comment #22)
> Hi,
> 
> This builds for me now finally, thanks.
> 
> Rpmlint output:
> 
>   W: spelling-error Summary(en_US) decryption
>   W: spelling-error %description -l en_US decryption
> 
> Ignore these spelling warnings, "decryption" is a valid noun form of the verb
> "decrypt." What a terrible dictionary it's using.
> 
>   W: non-conffile-in-etc /etc/maven/fragments/plexus-cipher
> 
> This is normal and may also be ignored.
> 
>   W: no-documentation
> 
> Please include the NOTICE.txt file as documentation in the main package.
Fixed.
> 
>   W: invalid-url URL: http://spice.sonatype.org/plexus-cipher HTTP Error 404:
> Not Found
>   W: invalid-url URL: http://spice.sonatype.org/plexus-cipher HTTP Error 404:
> Not Found
> 
> Please include a valid URL in the URL tag. I've tried this in my browser, there
> is definitely no page at this location.
Fixed.
> 
> ---
> 
> I've been through the guidelines and the review check list and I believe the
> package is acceptable except for the two items from the rpmlint output that
> I've highlighted above.    

Please review again, thanks.

Spec URL: http://huwang.fedorapeople.org/packages/plexus_cipher/plexus-cipher.spec
SRPM URL: http://huwang.fedorapeople.org/packages/plexus_cipher/plexus-cipher-1.5-3.src.rpm

here is the build link: http://koji.fedoraproject.org/koji/taskinfo?taskID=2221097

Nice one, that looks fine to me.

APPROVED

New Package CVS Request
=======================
Package Name: plexus-cipher
Short Description: Plexus Cipher: encryption/decryption Component
Owners: huwang
Branches: 
InitialCC:

CVS done (by process-cvs-requests.py).

Please don't put versions in the Summary of review tickets... ;)

Built in koji : http://koji.fedoraproject.org/koji/taskinfo?taskID=2228830