Bug 590625
Summary: | Review Request: maven-doxia-tools - Maven Doxia Integration Tools | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mary Ellen Foster <mefoster> |
Component: | Package Review | Assignee: | Alexander Kurtakov <akurtako> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | akurtako, dpierce, fedora-package-review, notting |
Target Milestone: | --- | Flags: | akurtako:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-05-11 15:07:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Mary Ellen Foster
2010-05-10 11:03:27 UTC
I'm taking this one. Review: OK: rpmlint must be run on every package. OUTPUT: maven-doxia-tools.noarch: W: spelling-error %description -l en_US plugins -> plug ins, plug-ins, plugging Not a problem. maven-doxia-tools.noarch: W: incoherent-version-in-changelog 1.2.1-2 ['1.2-2.fc12', '1.2-2'] Please Fix. maven-doxia-tools.noarch: W: no-documentation Not a problem, nothing suitable for doc. maven-doxia-tools.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-doxia-tools Not a problem. OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense. OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Large documentation files must go in a -doc subpackage. Javadocs subpackage. OK: If a package includes something as %doc, it must not affect the runtime of the application. OK: Packages must not own files or directories already owned by other packages. OK: All filenames in rpm packages must be valid UTF-8. Please do not BuildRequires: java-devel = 1:1.6.0 it should be BuildRequires: java-devel >= 1:1.6.0 Other than that package is good. This package is APPROVED. New Package CVS Request ======================= Package Name: maven-doxia-tools Short Description: Maven Doxia integration tools Owners: mef Branches: InitialCC: For reference, here is the final version: http://www.macs.hw.ac.uk/~mef3/maven221/maven-doxia-tools.spec http://www.macs.hw.ac.uk/~mef3/maven221/maven-doxia-tools-1.2-3.fc12.src.rpm CVS done (by process-cvs-requests.py). Remember to assign the review to the reviewer. Package Change Request ====================== Package Name: maven-doxia New Branches: epel7 Owners: mcpierce Git done (by process-git-requests). |