Bug 590777
| Summary: | Review Request: php-domxml-php4-php5 - XML transition from PHP4 domxml to PHP5 dom module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | Package Review | Assignee: | Johan Cwiklinski <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eric, fedora-package-review, fedora, notting |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | php-domxml-php4-php5-1.21.1-2.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-03 18:11:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Remi Collet
2010-05-10 16:53:32 UTC
*** Bug 549604 has been marked as a duplicate of this bug. *** Just a quick note, license should be LGPLv3+ instead of LGPLv3 according to source file header. Changes: http://github.com/remicollet/remirepo/commit/0a4e160010cbc9adde925e86404df5b64f688d54 New Spec: http://github.com/remicollet/remirepo/blob/master/php-domxml-php4-php5/php-domxml-php4-php5.spec SRPM : http://remi.fedorapeople.org/php-domxml-php4-php5-1.21.1-2.remi.src.rpm REVIEW: + rpmlint is clean php-domxml-php4-php5.src: I: checking => (false spelling-error from french removed and ignored) php-domxml-php4-php5.src: I: checking-url http://alexandre.alapetite.fr/doc-alex/domxml-php4-php5 (timeout 10 seconds) php-domxml-php4-php5.src: W: invalid-url Source0: domxml-php4-php5-1.21.1.tar.gz php-domxml-php4-php5.noarch: I: checking => (false spelling-error from french removed and ignored) php-domxml-php4-php5.noarch: I: checking-url http://alexandre.alapetite.fr/doc-alex/domxml-php4-php5 (timeout 10 seconds) php-domxml-php4-php5.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 12 warnings. + package is named according to the Package Naming Guidelines . + spec file name ok + The package meet the Packaging Guidelines and PHP Guidelines + license ok (LGPLv3) and match upstream + license provided + spec file is legible + sources match upstream a735ed6005551a49477b634004ca2c76 domxml-php4-to-php5.php + source URL not ok, but explained in the specfile + build on F13 x86_64 (php 5.3.3dev) + BuildRequires + no locale + no shared library (extension are not lib.) + no system library + own all directories that it creates + not list a file more than once in the spec + Permissions on files are set properly. + %clean ok + consistently use macro + contain code + no doc, no sub package + no -devel + no -static + no .pc + no .la + not own files or directories already owned by other packages + %install start with rm -rf $RPM_BUILD_ROOT + all files are UTF-8 + provides php-domxml-php4-php5 = 1.21.1-1.fc13 + requires php-xml >= 5.1 ***** APPROVED ***** Thanks for the review New Package CVS Request ======================= Package Name: php-domxml-php4-php5 Short Description: XML transition from PHP4 domxml to PHP5 dom module Owners: remi Branches: F-12 F-13 EL-5 EL-6 InitialCC: CVS Done php-domxml-php4-php5-1.21.1-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.fc13 php-domxml-php4-php5-1.21.1-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.fc12 php-domxml-php4-php5-1.21.1-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.el5 php-domxml-php4-php5-1.21.1-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-domxml-php4-php5'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.fc12 php-domxml-php4-php5-1.21.1-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-domxml-php4-php5'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.fc13 php-domxml-php4-php5-1.21.1-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-domxml-php4-php5'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/php-domxml-php4-php5-1.21.1-2.el5 php-domxml-php4-php5-1.21.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. php-domxml-php4-php5-1.21.1-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. php-domxml-php4-php5-1.21.1-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |