Bug 591414

Summary:	Spec file clean-up
Product:	Red Hat Enterprise Linux 4	Reporter:	Petr Pisar <ppisar>
Component:	quota	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED ERRATA	QA Contact:	qe-baseos-daemons
Severity:	medium	Docs Contact:
Priority:	low
Version:	4.8	CC:	azelinka, ovasik
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	quota-3.12-8.el4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-10-13 13:57:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2010-05-12 08:14:11 UTC

Current RHEL-4 quota-1:3.12-7 spec file contains some ugly things (RPM Guide Lines) and some files in resulting RPMs have improper attributes:

> $ rpmlint quota.spec x86_64/quota-*
> quota.spec:11: E: buildprereq-use e2fsprogs-devel gettext tcp_wrappers

Buildprereq has been obsoleted by BuildRequires keyword.

> quota.spec:258: W: macro-in-%changelog %attr)
> quota.spec:288: W: macro-in-%changelog %attr

The per-cent character must be escaped.

> quota.spec:84: W: mixed-use-of-spaces-and-tabs (spaces: line 84, tab: line 13)

The white spaces should be consistent to preserve alignment.

> quota.spec: W: invalid-url Source0: http://unc.dl.sourceforge.net/sourceforge/linuxquota/quota-3.12.tar.gz <urlopen error timed out>

The URL is no longer valid, correct one is <http://downloads.sourceforge.net/sourceforge/linuxquota/%{name}-%{version}.tar.gz>.

> quota.x86_64: W: summary-ended-with-dot C System administration tools for monitoring users' disk usage.

Trailing space from Summary must be removed.

> quota.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic

Use "file system" instead of "filesystem" in package description.

> quota.x86_64: W: non-conffile-in-etc /etc/quotagrpadmins
> quota.x86_64: W: non-conffile-in-etc /etc/quotatab

These file are configuration files. They must be attributed in such manner, otherwise package update will remove user modifications leading to undesired behavior.

> quota-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/quota-tools/quotasys.h

Header files are not executables. The executable bit must be removed.

As I have approved all RHEL-4 bugs for 4.9 fast track, I'd like to fix above-mentioned issues in this package update too.

Comment 5 errata-xmlrpc 2010-10-13 13:57:01 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2010-0767.html