Bug 591609

Created attachment 413493 [details]
email with exception

Description of problem:

If vdsmd doesn't return state of the machine in domain info, poller.py sends "Unknown" machine state to Satellite which causes exception, because Satellite doesn't know about "Unknown" state.


Version-Release number of selected component (if applicable):

Satellite 5.3 - spacewalk-backend-0.5.28-54
rhn-virtualization-host-5.3.0-17


How reproducible:

always


Steps to Reproduce:

1. Migrate xen to kvm guest through RHEVM (vdsmd has to be enabled at host)

  
Actual results:

see attached email (sensitive data removed)


Expected results:

no exception emails should be sent by Satellite


Additional info:

related client side source code (related code is concatenated with '<<<---'):

===< snip from client/tools/rhn-virtualization/virtualization/poller.py ===
def poll_through_vdsm():
   """
    This method polls all the virt guests running on a VDSM enabled Host.
    Libvirt is disabled by default on RHEV-M managed clients.
    * Imports the localvdsm client that talks to the localhost
      and fetches the list of vms and their info.
    * Extract the data and construct the state to pass it to the 
      execution plan for guest polling.
    * The server should account for business rules similar to
      xen/kvm.
   """
   import localvdsm
   try:
       server = localvdsm.connect()
   except:
       # VDSM raised an exception we're done here
       return {}
   # Extract list of vm's. True returns full list
   try:
       domains = server.list(True)
   except:
       # Something went wrong in vdsm, exit
       return {}

   if not len(domains['vmList']):
       # No domains, exit.
       return

   state = {}
   for domain in domains['vmList']:
       #trim uuid
       uuid = domain['vmId'].lower().replace('-', '')
       # Map the VDSM status to libvirt for server compatibility
       status = "Unknown"          <<<---
       if VIRT_VDSM_STATUS_MAP.has_key(domain['status']):  <<<---
           status = VIRT_VDSM_STATUS_MAP[domain['status']]
       # This is gonna be fully virt as its managed by VDSM
       virt_type = VirtualizationType.FULLY

       #Memory
       memory = int(domain['memSize']) * 1024

       # vcpus
       if domain.has_key('smp'):
           vcpus = domain['smp']
       else:
           vcpus = '1'

       properties = {
           PropertyType.NAME   : domain['vmName'],
           PropertyType.UUID   : uuid,
           PropertyType.TYPE   : virt_type,
           PropertyType.MEMORY : memory, # current memory
           PropertyType.VCPUS  : vcpus,
           PropertyType.STATE  : status}

       state[uuid] = properties

   if state: _log_debug("Polled state: %s" % repr(state))

   return state
=== snip >===

There is also probably a bug in routine which migrate host from xen to kvm with not updating domain status correctly through vdsm during migration, but the fact that the above code sends/could send unknown state for Satellite is a bug. It shouldn't send such state or should send one of the known states:

NOSTATE     = 'nostate'
RUNNING     = 'running'
BLOCKED     = 'blocked'
PAUSED      = 'paused'
SHUTDOWN    = 'shutdown'
SHUTOFF     = 'shutoff'
CRASHED     = 'crashed'

or there should be implemented another state named "Unknown".

Traceback from Satellite side (see attached email for complete info):

Exception Handler Information
Traceback (most recent call last):
  File "/usr/share/rhn/server/apacheRequest.py", line 120, in call_function
    response = apply(func, params)
  File "/usr/share/rhn/server/handlers/xmlrpc/registration.py", line 957, in virt_notify
    rhnVirtualization._virt_notify(server_id, actions)
  File "/usr/share/rhn/server/rhnVirtualization.py", line 844, in _virt_notify
    handler.handle(server_id, action)
  File "/usr/share/rhn/server/rhnVirtualization.py", line 214, in handle
    self.__convert_properties(properties)
  File "/usr/share/rhn/server/rhnVirtualization.py", line 773, in __convert_properties
    properties[PropertyType.STATE] = CLIENT_SERVER_STATE_MAP[state]
KeyError: 'Unknown'