Bug 592095

+++ This bug was initially created as a clone of Bug #589710 +++

Description of problem:
The ntpdate and netfs scripts (at least) run before NetworkManager
has configured networking.

Version-Release number of selected component (if applicable):
initscripts-9.12-1.fc13.x86_64
ntpdate-4.2.6p1-1.fc13.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Have a system network connection
2a. Have an nfs filesystem in /etc/fstab
2b. Have ntpdate run, possibly with a fqdn in /etc/ntp/step-tickers
3. Boot on a machine with sufficient cores to get the services starting
   up all at once.  I have 8 cores here.

Actual results:
ntpdate and nfs report [FAILED] due to nfs lookup failures.

Additional info:
Adding /usr/bin/nm-online -q somewhere in the scripts is probably the
right thing to do to delay their execution until the network comes up.
Although surely some sort of error checks are warrented as well.

--- Additional comment from rth on 2010-05-06 14:08:02 EDT ---

Gah. s/nfs/dns/ lookup failures.

--- Additional comment from notting on 2010-05-06 15:18:02 EDT ---

netfs has a /etc/NetworkManager/dispatcher.d dispatcher script that kicks it once NM has an address. I don't think ntp does.

netfs also has a check:
   start)
        [ ! -f /var/lock/subsys/network ] && [ ! -f /var/lock/subsys/NetworkManager ] && exit 0

but that doesn't mean the address is configured, of course.

--- Additional comment from rth on 2010-05-06 16:46:17 EDT ---

Perhaps we could add a "nm-online -x" check to the end of that test sequence
(and possibly move that whole sequence into /etc/init.d/functions)?  That
might at least make the initial running of S25netfs exit properly.

The state of affairs at the moment is somewhat disconcerting...

--- Additional comment from rth on 2010-05-06 16:54:09 EDT ---

... Something like

__networking_enabled() {
  if [ -f /var/lock/subsys/network ]; then
    exit 0
  fi
  if [ ! -f /var/lock/subsys/NetworkManager ]; then
    exit 0
  fi
  /usr/bin/nm-online -x
}

...
  start)
    __networking_enabled || exit 0