Bug 592140
Summary: | Enabling kdump at the end of firstboot fails | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | Brian Lane <bcl> | ||||||||||||
Component: | kexec-tools | Assignee: | Neil Horman <nhorman> | ||||||||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Han Pingtian <phan> | ||||||||||||
Severity: | medium | Docs Contact: | |||||||||||||
Priority: | low | ||||||||||||||
Version: | 6.0 | CC: | syeghiay | ||||||||||||
Target Milestone: | rc | ||||||||||||||
Target Release: | --- | ||||||||||||||
Hardware: | All | ||||||||||||||
OS: | Linux | ||||||||||||||
Whiteboard: | |||||||||||||||
Fixed In Version: | kexec-tools-2.0.0-70 | Doc Type: | Bug Fix | ||||||||||||
Doc Text: | Story Points: | --- | |||||||||||||
Clone Of: | Environment: | ||||||||||||||
Last Closed: | 2010-11-10 20:59:50 UTC | Type: | --- | ||||||||||||
Regression: | --- | Mount Type: | --- | ||||||||||||
Documentation: | --- | CRM: | |||||||||||||
Verified Versions: | Category: | --- | |||||||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
Embargoed: | |||||||||||||||
Bug Depends On: | |||||||||||||||
Bug Blocks: | 524819 | ||||||||||||||
Attachments: |
|
Description
Brian Lane
2010-05-14 00:23:20 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion. Hi Brian, I tried to reproduce this, I installed nightly from May 11th, with firstboot-1.110.2-1. In firstboot, right after restart, I enabled kdump, in the dialog about restart needed, I pressed Yes, and got no error message, everything went fine. So I could not reproduce it, can you try yourself again? I tried the install using the same .iso on a virt (single disk, use all space) and it enables kdump just fine. I tried running firstboot on the EFI system and it had the same problem. I did a reinstall just to be sure and it still won't enable kdump. I'll attach my grub.conf and parted -l output. Let me know if there are any other files to look at, as far as I can tell firstboot isn't logging anything. Created attachment 414116 [details]
grub.conf from EFI system install
Created attachment 414117 [details]
output of parted -l on the EFI system
More info: /boot is mounted, but some of the files are in different locations. /etc/grub.conf exists (attached above) /boot/grub/ only has device.map and splash.xpm.gz in it, no grub.conf /boot/efi is a separate partition and it has grub.conf in it: /boot/efi/EFI/redhat/grub.conf /boot/efi/EFI/redhat/grub.efi So, if firstboot/kdump is looking for /boot/grub/grub.conf it isn't going to find it. /etc/grub.conf is a symlink to /boot/efi/EFI/redhat/grub.conf yeah, we're looking for /boot/grub/grub.conf. I'll put together a patch Created attachment 415083 [details]
patch to look for grub.conf correctly
I think this should do it, could you please test this out and confirm that firstbook works properly for you? Thanks!
That won't work, you're adding a new grub entry pointing to the efi config, but that overwrites the previous entry in the dict. I'd suggest either testing for /etc/grub.conf (assuming it always points to the right place -- I don't know enough to be sure of this) or making the bootloaders dict support lists of config files to test for, eg: bootloaders = { "grub" : [("/boot/grub/grub.conf", 16), ("/boot/efi/EFI/redhat/grub.conf", 256)], "yaboot" : [("/boot/etc/yaboot.conf", 32)], "elilo" : [("/boot/efi/EFI/redhat/elilo.conf", 256)], } Dang your right, its a dict not a list of lists. I'll fix up the patch to do the latter suggestion I think. Thanks! Created attachment 415243 [details]
updated patch
here you go. I've not tested it yet, but I think this should make the bootloaders dictionary list aware, and let us match multiple entries for each name.
Created attachment 415284 [details]
working patch
Attached is a tested patch. I store the offset in the instance so that the bootloaders don't need to be scanned every time the offset is needed. Red Hat Enterprise Linux 6.0 is now available and should resolve the problem described in this bug report. This report is therefore being closed with a resolution of CURRENTRELEASE. You may reopen this bug report if the solution does not work for you. |