Bug 592208

I can do this one.

(In reply to comment #1)
> I can do this one.    

when you take a package you're supposed to change the status to Assigned

Also set the fedora-review flag to '?' :-)

Ugh,  could have sworn I did that, what a half-job i'm doing. Good job nobody's paying me to do this  :-)

Does the final argument to %add_to_maven_depmap need to be %{short_name} like the other commons packages? And does it also need to contain the legacy depmap for backwards compatibility?

You were correct on both accounts. Fixed in r2 together with few other tweaks:

SRPM URL: http://sochotni.fedorapeople.org/apache-commons-daemon-1.0.2-2.fc13.src.rpm
Spec URL: http://sochotni.fedorapeople.org/apache-commons-daemon.spec

This package looks good. I'm happy that all the rpmlint output is false, unless you really want to capitalise the (TM) trademark symbol...

The only thing I'd say is that it looks to me like only the jsvc sub-package contains anything arch-specific. The base package and the javadoc sub-package could (should?) be noarch. If you do that for release 3, then consider this package APPROVED!

I wanted to make only jsvc subpackage arch specific, but apparently there is no way to instruct rpm to do this. You can either have whole package (and subpackages) arch specific or noach. There is no way to mix-and-match. At least that's what I was told when I asked the RPM guys. If there is a way to do this, it's probably a hack...

As for the TM, according to our guidelines it should not even be there (https://fedoraproject.org/wiki/Packaging/Guidelines#Trademarks_in_Summary_or_Description). So I will remove it before commiting to CVS.

In good faith that I explained those two issues...Requesting CVS:

Thanks. Requesting CVS:

New Package CVS Request
=======================
Package Name: apache-commons-daemon
Short Description: Defines API to support an alternative invocation mechanism
Owners: sochotni
Branches: 
InitialCC:

(In reply to comment #8)
> I wanted to make only jsvc subpackage arch specific, but apparently there is no
> way to instruct rpm to do this. You can either have whole package (and
> subpackages) arch specific or noach. There is no way to mix-and-match. At least
> that's what I was told when I asked the RPM guys. If there is a way to do this,
> it's probably a hack...
> 

It's no hack. With version 4.6.0 RPM supports sub-packages being noarch by just adding "BuildArch: noarch" to their sub-package section in the spec file.

Please do so for at least the javadoc package.

Ah, you are(In reply to comment #9)
> (In reply to comment #8)
> > I wanted to make only jsvc subpackage arch specific, but apparently there is no
> > way to instruct rpm to do this. You can either have whole package (and
> > subpackages) arch specific or noach. There is no way to mix-and-match. At least
> > that's what I was told when I asked the RPM guys. If there is a way to do this,
> > it's probably a hack...
> > 
> 
> It's no hack. With version 4.6.0 RPM supports sub-packages being noarch by just
> adding "BuildArch: noarch" to their sub-package section in the spec file.

Yes, but what is really needed here is to have main package noarch, and one subpackage arch specific...and that is apparently not possible now.

> Please do so for at least the javadoc package.    

This is true, and fixed in r3

SRPM URL:
http://sochotni.fedorapeople.org/apache-commons-daemon-1.0.2-3.fc13.src.rpm
Spec URL: http://sochotni.fedorapeople.org/apache-commons-daemon.spec

Ok, thanks. :-)

CVS done (by process-cvs-requests.py).

Package built on koji:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2237470


Thanks all.