Bug 592504

Summary: Review Request: nodebrain - a declarative rule-based language for state and event monitoring
Product: [Fedora] Fedora Reporter: John Ellson <john.ellson>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, martin.gieseking, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-10 18:34:07 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description John Ellson 2010-05-14 21:58:28 EDT
Spec URL: http://john.ellson.com/nodebreain.spec
SRPM URL: http://john.ellson.com/nodebrain-0.8.0-1.fc11.src.rpm
Description:   NodeBrain is an interpreter of a declarative rule-based language
designed for construction of state and event monitoring applications. It
interacts with other monitoring components to perform simple element state
monitoring or complex event correlation based on user specified rules. It is
extended through the development of node modules (plug-ins) using NodeBrain's
C API, and servants (programs written in any language) that interact with
NodeBrain via stdin, stdout, and stderr. A small set of plug-ins are
distributed with NodeBrain to provide commonly needed features such as
peer-to-peer communication, log monitoring, event caching, and a
web browser interface for administrators.

Upstream developer:  Ed Trettevik <eat@nodebrain.org>
Packager:  John Ellson <john.ellson@comcast.net>
Comment 2 John Ellson 2010-09-22 10:00:55 EDT
Updated.

Spec URL: http://john.ellson.com/nodebrain.spec
SRPM URL: http://john.ellson.com/nodebrain-0.8.0-1.fc14.src.rpm


Could someone please take a quick look and tell me what I have to do nesxt?
Comment 3 Martin Gieseking 2010-10-19 16:09:53 EDT
Hi John,

is this your first package submission for Fedora? I can't find your email address in the packager scm commit group. If so, please add FE-NEEDSPONSOR to the Blocks field above and see the following wiki page for further information:
https://fedoraproject.org/wiki/PackageMaintainers/Join#How_to_join_the_Fedora_Package_Collection_Maintainers.3F
Comment 4 John Ellson 2010-10-23 09:38:36 EDT
I've not been an active/primary package maintainer before, but I thought I was registered as co-maintainer for graphviz.  Perhaps under by business email address: ellson@research.att.com ? 

No matter, I've added FE-NEEDSPONSOR, I would certainly appreciate any help getting this package moving.
Comment 5 Jason Tibbitts 2010-11-19 14:16:52 EST
Current comaintainers for graphviz are alexlan and tremble; I don't think you're in there.

Some random comments:

0.8.3 seems to be available.

If you can do a parallel make (using %{?_smp_mflags}), please do so; otherwise please indicate in a comment why it does not work.  Who likes to wait when we all have multicore machines these days?

Please use the recommended scriptlets from http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo.

rpmlint complains many times about dangling symlinks:
  nodebrain-devel.x86_64: W: dangling-relative-symlink
   /usr/lib64/nb/nb_peer.so nb_peer.so.0.0.1
which is a bit odd.  I think the issue is that rpmlint doesn't understand things going in a subdirectory of _libdir, but then that begs the question of just what the stuff in /usr/lib(64)/nb really is.  If that stuff is just plugins that are dlopen'ed, there's probably no need for them to have devel symlinks.  lib/nbmodule.c:nbModuleLoad does imply that there are dlopen'ed plugins.

  nodebrain.x86_64: E: zero-length /usr/share/doc/nodebrain-0.8.0/ChangeLog
Any idea why the ChangeLog is empty?  Is there any point in shipping it if it's empty?

  nodebrain.x86_64: W: file-not-utf8 /usr/share/info/nbTutorial.info.gz
It looks like there's some kind of weird microsoft-encoded single-quite stuff in nbTutorial.info:
  illustrate this, let<92>s first write a simple Perl script named
Should probably be replaced with a proper single quote.  There may be more stuff in there; I didn't search through the entire 4000 line document.

  nodebrain.x86_64: W: no-manual-page-for-binary nb-0.8.0
This is OK; the nb link has a manpage.

  nodebrain-debuginfo.x86_64: E: debuginfo-without-sources
This implies that either the executables are being stripped, or the program isn't compiled with the proper flags.  It looks like it's the latter; for whatever reason, the configure script is ignoring the OS-supplied compiler flags.  This must be fixed.