Bug 592668

I sent an email to upstream about the omission of the Pure Data license file from the source distribution, and he indicated that he planned to add it soon.

I made a full review. The package is in good shape. I checked the plugin and it works fine. It doesn't seem to be in the correct ladspa categorization. It should probably go to pitch shifters or something, but this is not a blocker and can be fixed if there is a user request. It also built fine in koji rawhide:
   http://koji.fedoraproject.org/koji/taskinfo?taskID=2204555

But I have concerns about the licensing and the patents.

- rpmlint complains about some spelling errors
   ladspa-autotalent-plugins.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging  
   ladspa-autotalent-plugins.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging      
   ladspa-autotalent-plugins.src: W: spelling-error %description -l en_US chiptune -> chip tune, chip-tune, chipmunk 
   ladspa-autotalent-plugins.src: W: spelling-error %description -l en_US formants -> formats, form ants, form-ants

which, I believe, can be ignored.


* The guidelines say:
   If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc
   (from  http://fedoraproject.org/wiki/Packaging:ReviewGuidelines)

I think the inclusion of an external license file is not what we want. Thanks for contacting upstream about this issue. Let's hope he will add a license notice in his tarball.

I am also concerned about the license of the .pdf file you are bundling. Sometimes the documentation comes with a different license than the software' and sometimes the documentation is not free. Did you ask about the license of the .pdf file?

The biggest question is the nature and the dates of the patents that are mentioned in mayer_fft.c. They don't give us a patent number, I don't know how we can check it. Any ideas? (If the patent is still effective, then the package is rpmfusion material.)

Thanks for taking a look at this package.
I probably should have put links to the discussion of this package on fedora-legal-list.

My original post:
http://lists.fedoraproject.org/pipermail/legal/2010-May/001272.html
The response I received:
http://lists.fedoraproject.org/pipermail/legal/2010-May/001273.html

The recommendation of the list was that it could be packaged, with the recommendation that the Pure Data license file be included, and the License: be set to GPLv2+ and BSD.

However, as you point out, the pdf file is under a different license.  The markings in the lower left corner indicate that it is under a Creative Commons Attribution No Derivatives license, which is considered a good license for content.  I have made a new package with the license tag changed to reflect the license for that documentation.

Spec URL: http://www.davidcornette.com/ladspa-autotalent-plugins.spec
SRPM URL:
http://www.davidcornette.com/ladspa-autotalent-plugins-0.2-2.fc11.src.rpm

As for the patents, I believe they are not a concern.  It is referring to U.S. Patents 4646256 and 4878187.  According to http://www.freepatentsonline.com/4646256.html , the first was filed on 03/19/1984 and published on 02/24/1987.  This expired in 2004.  The second is found at http://www.freepatentsonline.com/4878187.html and was filed on 06/22/1988 and published 10/31/1989, so it expired in 2008.

Alright then. Based on your patent investigation and FE-Legal's license approval, this package is good to go.

------------------------------------------------------------
This package (ladspa-autotalent-plugins) is APPROVED by oget
------------------------------------------------------------

Upstream has issued a new tarball with the license for the Pure Data source files.  I made a new version:

Spec URL: http://www.davidcornette.com/ladspa-autotalent-plugins.spec
SRPM URL:
http://www.davidcornette.com/ladspa-autotalent-plugins-0.2-3.fc11.src.rpm

Would you like to take a look at it before I proceed? Or is this just a case of updating a package after it has been approved, even though it hasn't even been put in CM?

I don't think we have a guideline for doing changes to a package after approval and before the commit. Usually the reviewers expect the approved version to be imported, or at least no major changes have been made in between. It is good to ask the reviewer, just as you did.

In this case the changes are minimal. So no problems from my side. Go ahead and ask for cvs.

New Package CVS Request
=======================
Package Name: ladspa-autotalent-plugins
Short Description: A pitch correction LADSPA plugin
Owners: davidcornette
Branches: F-12 F-13
InitialCC:

CVS done (by process-cvs-requests.py).

ladspa-autotalent-plugins-0.2-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/ladspa-autotalent-plugins-0.2-3.fc12

ladspa-autotalent-plugins-0.2-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/ladspa-autotalent-plugins-0.2-3.fc13

ladspa-autotalent-plugins-0.2-3.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ladspa-autotalent-plugins'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ladspa-autotalent-plugins-0.2-3.fc12

ladspa-autotalent-plugins-0.2-3.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ladspa-autotalent-plugins'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ladspa-autotalent-plugins-0.2-3.fc13

ladspa-autotalent-plugins-0.2-3.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

ladspa-autotalent-plugins-0.2-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.