Bug 592770
Summary: | Review Request: texmakerx - LaTex Editor | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | hannes <johannes.lips> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 13 | CC: | fedora-package-review, notting, rdieter |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-09-03 10:00:23 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
hannes
2010-05-16 20:22:00 UTC
Hello, due to a bug I need to compile a new version with another hunspell version. It could be found here: http://dl.dropbox.com/u/3917796/texmakerx.spec http://dl.dropbox.com/u/3917796/texmakerx-1.9.9-2.fc13.x86_64.rpm Hannes, In spite of this being an informal review, consider the following suggestion, please: 1. include texlive-latex as requirement otherwise Tex commands will not be available. However, you should not submit review requests for an existing package in Fedora -- https://admin.fedoraproject.org/pkgdb/acls/name/texmaker -- you should seek for co-maintainership instead. Take a look at: https://fedoraproject.org/wiki/PackageMaintainers/Join Regards Hello Rafael, this program isn't equal to the normal texmaker (mind the little x at the end) ;) The new dependency is something to think about. Greetings Hello Hannes, As I said before, it's just an informal review. However, consider the following observation, please. (In reply to comment #3) > this program isn't equal to the normal texmaker (mind the little x at the end) > ;) So, it would be better if you have said that TexMakerX is a fork of Texmaker IDE in your Spec description. Also, you should evidence TexMakerX's differences/improvements regarding to TexMaker. Think how confusingly could be to an ordinary user trying to choose which of two packages to install and the only difference he/she is noticing is a little 'x' in package's name. Best regards. Ok I added another description. Just noticed today that this description was the one of texmaker. I added the description of the texmakerx guys which is presented on their homepage. I hope this is going to improve the package. Anyway thanks for your comments. Greetings Johannes, As a best practice, you should change the release number of you package every time you modify the spec file in order to avoid confusion. Also, it would be nice if you could submit a new comment on this bug, with the URL for the new SRPM built on those Spec modifications. Regards Well, the bug was that TexmakerX was crashing if you tried to choose a dictionary. With a new version of hunspell in the package this problem was gone. It takes really long to compile this package despite my pc is recent. So I don't want to compile it the whole day, sorry. I didn't know that you have to change the release number everytime you change the spec. I'll do in the future... http://dl.dropbox.com/u/3917796/texmakerx-1.9.9-2.fc13.src.rpm I checked the packages and the spec with rpmlint and there weren't any errors. Greetings Johannes, (In reply to comment #7) > It takes really long to compile this package despite my pc is recent. So I > don't want to compile it the whole day, sorry. Well, if the question was just a matter of rebuilding and shipping a new SRPM without having to go through your long build process, I think a simple 'rpmbuild -bs texmakerx.spec' would be sufficient to you. > I didn't know that you have to change the release number everytime you change > the spec. I'll do in the future... Yes, whenever a minor change (spec file changed, patch added/removed) occurs, or a package is rebuilt to use newer headers or libraries, the release number should be incremented. You can find further information on this subject at: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Release Here has a good reference, also: http://fedoraproject.org/wiki/Packaging/FrequentlyMadeMistakes Well, it seems to me that your package is OK. 1) rpmlint does not have any complaint at all: $ rpmlint -i SPECS/texmakerx.spec SRPMS/texmakerx-1.9.9-2.fc12.src.rpm RPMS/x86_64/texmakerx-1.9.9-2.fc12.x86_64.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. 2) mock build is OK, too $ mock -r fedora-12-x86_64 --rebuild SRPMS/texmakerx-1.9.9-2.fc12.src.rpm INFO: mock.py version 1.0.7 starting... State Changed: init plugins State Changed: start INFO: Start(SRPMS/texmakerx-1.9.9-2.fc12.src.rpm) Config(fedora-12-x86_64) . . INFO: Done(SRPMS/texmakerx-1.9.9-2.fc12.src.rpm) Config(fedora-12-x86_64) 8 minutes 38 seconds INFO: Results and/or logs in: /var/lib/mock/fedora-12-x86_64/result I hope you get your work formally reviewed by a sponsor, very soon! Regards Updated to latest version: http://dl.dropbox.com/u/3917796/texmakerx-1.9.9a-1.fc13.src.rpm naming: ok scriptlets: ok licensing: ok sources: ok 0bf125729f39a22365bc33153a8e28a7 texmakerx-1.9.9a.tar.gz rpmlint: $ rpmlint *.rpm texmakerx.src:33: W: macro-in-comment %patch1 1 packages and 0 specfiles checked; 0 errors, 1 warnings. (omit reference, or drop the % APPROVED. (what's your fas username? given that, I can sponsor you) Hello, my fas username is: hannes I'll fix that warning when I get home and will upload a version without that code snippet. Thank you! Fixed: http://dl.dropbox.com/u/3917796/texmakerx-1.9.9a-2.fc13.src.rpm Greetings ok, sponsored now (you should get some confirmation mail from our accounts system). New Package SCM Request ======================= Package Name: texmakerx Short Description: LaTeX Editor Owners: hannes Branches: f13 f14 InitialCC: Git done (by process-git-requests). build in rawhide: http://koji.fedoraproject.org/koji/packageinfo?packageID=10845 |